Jump to content

Featured Replies

Posted

Hi team,

In IC 4.7,20, it seems I've found an issue in the template:
/core/dev/html/front/global/review.phtml

On line 124, we can see the following conditions:

{{if ( member.member_id and ( !$review->mapped('votes_data') or !array_key_exists( member.member_id, json_decode( $review->mapped('votes_data'), TRUE ) ) ) ) || $review->canEdit() || $review->canDelete() || $review->canHide() || $review->canUnhide() || ( $review->hidden() !== 1 && \IPS\IPS::classUsesTrait( $review, 'IPS\Content\Reactable' ) and settings.reputation_enabled and $review->hasReactionBar() )}}

However, within these conditions, there's no mention of the condition $review->canRespond()

Yet just a few lines below, on line 155, we see:

{{elseif $review->hidden() !== 1 && $review->canRespond()}}

As a result, in certain cases, it is not possible to respond to a review : even if $review->hidden() !== 1 && $review->canRespond() is true, it will never be called if the other conditions on line 124 are false.

I think the $review->hidden() !== 1 && $review->canRespond() condition is missing on line 124.

Thank you!

Thank you for bringing this issue to our attention! I can confirm this should be further reviewed and I have logged an internal bug report for our development team to investigate and address as necessary, in a future maintenance release.

Recently Browsing 0

  • No registered users viewing this page.