teraßyte Posted March 23 Share Posted March 23 (edited) In \applications\convert\Application.php there is no check to redirect old vBulletin links. It only checks for Expression, Vanilla, Xenforo, and SMF: public function convertLegacyParameters() { $_qs = ''; if ( isset( $_SERVER['QUERY_STRING'] ) ) { $_qs = $_SERVER['QUERY_STRING']; } elseif ( isset( $_SERVER['PATH_INFO'] ) ) { $_qs = $_SERVER['PATH_INFO']; } elseif ( isset( $_SERVER['REQUEST_URI'] ) ) { $_qs = $_SERVER['REQUEST_URI']; } /* Expression Engine */ preg_match ( '#(viewforum|viewthread|viewreply|member)\/([0-9]+)#i', $_qs, $matches ); if( isset( $matches[1] ) AND $matches[1] ) { static::checkRedirects(); } /* Vanilla */ preg_match ( '#(discussion|profile)\/([0-9]+)\/#i', $_qs, $matches ); if( isset( $matches[1] ) AND $matches[1] ) { static::checkRedirects(); } /* Xenforo */ preg_match ( '#(forums|threads|members)\/(.*)\.([0-9]+)#i', $_qs, $matches ); if( isset( $matches[1] ) AND $matches[1] ) { static::checkRedirects(); } /* SMF */ if( \IPS\Request::i()->board OR \IPS\Request::i()->topic OR \IPS\Request::i()->action ) { static::checkRedirects(); } } These vBulletin links are not checked at all: forumdisplay.php viewtopic.php showthread.php member.php album.php picture.php Edited March 23 by teraßyte Link to comment Share on other sites More sharing options...
Jim M Posted March 23 Share Posted March 23 Thank you for bringing this issue to our attention! I can confirm this should be further reviewed and I have logged an internal bug report for our development team to investigate and address as necessary, in a future maintenance release. Link to comment Share on other sites More sharing options...
Stuart Silvester Posted March 23 Share Posted March 23 That's because it's legacy code (note it's in a method for dealing with legacy parameters). Redirects are handled with a hook on the front dispatcher. If the request results in a 404, it'll check the Converter applications. Link to comment Share on other sites More sharing options...
teraßyte Posted March 23 Author Share Posted March 23 Okay, I see what you mean now @Stuart Silvester. But the check for viewtopic.php is the one still missing from the redirect code. I see only showthread.php and showpost.php. Link to comment Share on other sites More sharing options...
Solution Stuart Silvester Posted March 23 Solution Share Posted March 23 vBulletin didn't use viewtopic.php, it used showthread.php Link to comment Share on other sites More sharing options...
teraßyte Posted March 23 Author Share Posted March 23 Maybe they had some kind of 3rd party modification then. 🤨 Oh well, all good then. I'll deal with it myself. Link to comment Share on other sites More sharing options...
Ryan Ashbrook Posted March 23 Share Posted March 23 1 hour ago, teraßyte said: Maybe they had some kind of 3rd party modification then. 🤨 Oh well, all good then. I'll deal with it myself. viewtopic.php is most likely phpBB, which they may have used prior to vBulletin. SJ77 1 Link to comment Share on other sites More sharing options...
Recommended Posts