Jump to content

4.7.2.1 - disable app


bosss

Recommended Posts

5 minutes ago, Matt said:

Show me your code and the base code. 
 

I did see we used \IPS\node\Controller instead of an uppercase “Node”. Is that what you’re seeing?

Mine:

	protected function _createOrUpdate( \IPS\node\Model $node )

\IPS\Node\Api\NodeController:

	protected function _createOrUpdate( \IPS\Node\Model $node )

Yes.

So now will have to update everything again?

4.7.2 is

	protected function _createOrUpdate( \IPS\node\Model $node )

 

Link to comment
Share on other sites

23 minutes ago, Adriano Faria said:

Mine:

	protected function _createOrUpdate( \IPS\node\Model $node )

\IPS\Node\Api\NodeController:

	protected function _createOrUpdate( \IPS\Node\Model $node )

Yes.

So now will have to update everything again?

4.7.2 is

	protected function _createOrUpdate( \IPS\node\Model $node )

 

Unfortunately that's the nature of these types of things now causing fatal errors. Matt did a pass of some stuff that wasn't consistent in our own code but in future non-major releases we're going to be mindful to avoid changing method signatures unless we really need to - sometimes it's just not possible to avoid.

Link to comment
Share on other sites

@Matt, can't this be avoided somehow?

SkO08qL.png

I'm using a resource that has a hook to another that isn't installed. 3 pages of log entries about this in 10 minutes I'm working on it.

Users will freak out with so many log entries; support will say it's a 3rd-party issue; we will say it's a scanner overkill, bla bla bla...

Link to comment
Share on other sites

5 minutes ago, Adriano Faria said:

@Matt, can't this be avoided somehow?

SkO08qL.png

I'm using a resource that has a hook to another that isn't installed. 3 pages of log entries about this in 10 minutes I'm working on it.

Users will freak out with so many log entries; support will say it's a 3rd-party issue; we will say it's a scanner overkill, bla bla bla...

We'll be decreasing the verbosity of some of the logging in future releases

 

Link to comment
Share on other sites

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...