Jump to content

Navigation Toolkit [Support Topic]


shahed
 Share

Recommended Posts

@shahed

There several issues with dark mode that i've encountered.
Looking forward to some improvements for it.

Also, what's pretty annoying is that on each new page load, it always shows the page in light mode for a split second.
That's really hard on your eyes when it's night. That's most likely the worst about this plugin. Really hope that can be adressed.
 

The Text Editor is rock bottom:

image.png.d223dc4bb91a1de13156f5007c133357.png

 

Author box:
image.png.c3d6013c12f1782b3c671d713f7a4702.png
image.png.c58181ecb28ce8bd4ab60652955c0694.png

 

There are black icons in topic edit mode

image.png.3390a75bc50da310e02ca2dd99eb4f23.png

 

Page categories:
image.png.6c99bca56464067164cb56a259434cee.png 

image.png.ccb8dea14e075b8a97a52a5229e44dfa.png

 

Sub Menu

image.png.ab9ab53ca2ebc3f539f7cfdcd77e737d.png

image.png.1fd846ba2c43d6b6276298760fba0d5a.png

 

Page Categories missing icons:
image.png.dcdfd4470f0b91eb3d595882f49d35a1.png

image.png.f7f241de026fc9090b7c5a13de002274.png

 

Inconsistent green label on pages:
image.png.d2e44f37ae6dc31a588c01b45f40ae15.png    image.png.7e8466c96774ffcb44faaa4a6f4bb06b.png

 

When looking at text editor SOURCE CODE the background is white, text too...
image.png.696da1fa50f36396fed1954581d50103.png

 

 

Suggestion:

It would also be great if we could set some of the main colors ourselfs.

 

 

Edited by Everade
Link to comment
Share on other sites

10 hours ago, Everade said:

There several issues with dark mode that i've encountered.
Looking forward to some improvements for it.

Thanks @Everade for reporting.

Every issue that are being reported (editor, quotes, badges, etc) will be fix in 1.0.2 // Navigation Toolkit 1.0.1 are already submitted for the review in marketplace.

 

There are however a few notes:

10 hours ago, Everade said:

Also, what's pretty annoying is that on each new page load, it always shows the page in light mode for a split second.

This is because plugin uses JavaScript method for storing user selections. and JS files loads during page load.

 

10 hours ago, Everade said:

It would also be great if we could set some of the main colors ourselfs.

There are so many CSS class variable in place and adding setting for them is really not the direction I want to go with this plugin. though I must mention that I have some ideas for easier customization.

Link to comment
Share on other sites

2 hours ago, Eric BXL said:

I like this plugin but I am missing the "Show/Hide Global sidebar".

Is that not implemented yet?

Sorry for the confusion. it is one of the new feature in 1.0.1 and you can see in demo website. I had submitted this version about three days ago and updated the feature list as such. since then this version awaits for approval by MP team.

Link to comment
Share on other sites

6 hours ago, Everade said:

There's an event listener error in the web console with "Text resize button" disabled.

I'm not sure what error is reported here and I can't reproduce it. can you send screenshot of the error? when I'm disable "Text resize button" it will disappear from public use and no error being caused.

Link to comment
Share on other sites

Thanks for the update.
However there are still some leftover issues.

In mobile view, social icons are displayed instead of hidden:
Please hide them just live in the official design.
image.png.af679ed0171c027fd8ebb57e7dac535e.png

 

Dark mode also has still several issues such as:
Topics Widget for the ipsCommentCount is invisible.

image.png.be8e9d1993a68dbc43c0a61ae174b4ea.pngimage.png.55a1fa8743ed137dfc9c3dec338eb4cb.png

 

Manage Promoted Items Page:
image.png.1293adabfcdd7df0194b76a0c7ee17cd.pngimage.png.2d8993caa159a5f47eb4f365924bbc75.png

 

Not all Field Labels for Pages are not optimized for dark mode.
Some are barely visible, if at all.
This is just an example of some of the listing view formats:
image.png.557b8ff66b9f677821f403d1fd86d505.pngimage.png.a3b6d3c58caf58d63d13773eb586f7e6.png

Date of Incident is almost invisible:
image.png.4ef36e45223dad125bc80a2202eb2c80.pngimage.png.b2cac63a5e413d3a3d34934691b9e9d5.png

For example your Legend News uses this black label as well.
The category is almost invisible:
image.png.9a80ea8c1f7430961357ba036fe28054.pngimage.png.92271481b33e669ad301beac96be98d4.png

These are defined on Page Field Settings and can be picked as shown here:
They look fine in the dark mode of the admin panel though.
image.png.e6b73d15198a33bd081772f59c591015.png

 

Also the addEventListener error  that i reported to you still perists in the plugins.js
However this time around you duplicated the warning and error with the addition of the new function, which by the way also refers to fontBtn which is for sure a copy/paste mistake.

Would be great if you could resolve these errors soon.

image.png.84e356067322a41ae4def2122bb9ac89.png

image.png.84e356067322a41ae4def2122bb9ac89.png

image.png.a4b7643d352b4761c541d6b8314d18ad.png

image.png.47775bc2b565e2e6f98c210ad2de5f64.png

image.png.7cc461d1da9c13aca61fd86d0e88d546.png

Link to comment
Share on other sites

  • 1 month later...
44 minutes ago, Everade said:

Could you increase the space between the day/night button and the menu? (mobile only)
It's very close on mobile.

image.png.8f7c1a10c3efdbb5fb489fa33f499af2.png

 

Sure. will be implement in future updates. quick fix would be adding this class in your theme's custom.css at the end of the file.

@media screen and (max-width: 767px) {
	.MVN_themeToolkit label {
	    margin-right: 5px;
	}
}

 

Link to comment
Share on other sites

  • 2 weeks later...
2 hours ago, Everade said:

Latest update broke your Legend News system css for dark mode:


image.png.3c557d185a5ccc1d772fbb882ac7bb9a.png

Yes, sorry about that. there is a upcoming Legend News update is under way and based on that there was no need for relevant Legend News classes in Navigation Toolkit. so they are permanently removed from this plugin. but as of now until News update come, you can add this class to your theme's custom.css at the end of the file.

html[data-theme="dark"] .legend_card_container {
    background: rgba( var(--theme-area_background),.5 ) !important;
}

 

Link to comment
Share on other sites

  • 11 months later...
2 hours ago, Alex Duffy said:

Great work, I love most of its features, but the dark more is not compatible with much of the print, it just doesn't show. I think that is an important feature and would like to see it fixed. But even without this it's still a very useful plug-in.

I should add its not compatible with Pages SuperGrid 3.2. The text does not show up and the images on the listings are also affected. Apart from that it seems to work well. 

 

Link to comment
Share on other sites

10 hours ago, Alex Duffy said:

Great work, I love most of its features, but the dark more is not compatible with much of the print, it just doesn't show. I think that is an important feature and would like to see it fixed. But even without this it's still a very useful plug-in.

Hi,

What is the print?

7 hours ago, Alex Duffy said:

I should add its not compatible with Pages SuperGrid 3.2. The text does not show up and the images on the listings are also affected. Apart from that it seems to work well. 

Well... extend of support for public releases are normally limited to Invision apps or my own, as simply I don't own/have other third-party resources, so on that part there is nothing to support to begin with.

I only can say how my plugin works, so maybe helps to make other templates work with as well.

  • For css file, this plugin uses "navigationtoolkit.css" can be found in your theme edit CSS and HTML
  • Now, any custom class that exist in your website can be put through this format and will change style in Dark Mode:
html[data-theme="dark"] .customClass {
    background: #333;
}

You can add any class in navigationtoolkit.css by this format, and that class will have different style in Navigation Toolkit's Dark mode. 👍

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...