Kitchen Sink

[All Astronauts]

FYI I submitted a 2.2.1 version just now. Clears out some javascript errors from the console when the sidebar is not present at all. Also had some dupe code cruft related to this I cleared out. No big deal if you are running 2.2.0 (nothing will crash or anything) but when this revision appears do upgrade.

[OptimusBain]

Hello, trust you are doing well.

I had a couple of suggestions for this application. I love it, by the way 🙂

1. Possibility of changing the product's default listing to expanded/reduced. Right now there is no possibility to do that 

2. Possibility of choosing the number of text lines that the product's short description will display in the products listing. Right now, it's just a couple of lines and when the product has s renewal, the price will eat up two of those lines, rendering the description useless.

3. The product's description detail page is truncated to a couple of lines, making the upper with are where the description is placed useless. Adding an option to choose how many lines of text should be displayed would be great.

Thanks a lot. 

[Genestoy]

I would like to make a suggestion since I just ran into this as I posted a topic in IPS support about the file upload number limit.

Could it be possible to have a setting for the admin so they can have "unlimited" number of file uploads?

I had forgotten about that setting and was trying to upload some additional files and it would not let me so posted in the IPS support forum about where the setting was (which I finally remembered where it was).

Thanks

[All Astronauts]

Is this for attachments?

[Genestoy]

22 minutes ago, All Astronauts said:

Is this for attachments?

Yes

Edited June 16, 2022 by Genestoy

[All Astronauts]

We got rocked with storms late afternoon yesterday and I'm going to take advantage of these next-day high winds (less bugs, great noise) to hit the trails to go running and see the damage so that's me saying I'm too lazy to look right now (on phone) but I'm pretty sure KS has this setting already, just not as a per-group setting. Which would be doable.  We're talking about the same thing?

Edited June 16, 2022 by All Astronauts

[Genestoy]

Yes, I think so, as long as the admin can set it so they can do unlimited attachments. Thanks for looking into this!

[All Astronauts]

Alright I'll add an admin override and skip the group stuff, just a yes no toggle for admins unlimited

[Genestoy]

Perfect, that will help a lot!

Thank You!

[All Astronauts]

And I just skipped the toggle altogether and opted for just an admin check. If admin, no limit.

[Genestoy]

Great, when will it be ready?

Thanks

[OptimusBain]

Good day @All Astronauts

Just wanted to report an issue with Kitchen Sink. 

When I choose to hide the MultiQuote Button, the + multi quote button will not be hidden and the quote icon will disappear. 

There is no way I could find to disable the multi quote button and only leave the quote icon.

is that a known problem?

thanks 

[All Astronauts]

This on 4.7.x?

[OptimusBain]

1 hour ago, All Astronauts said:

This on 4.7.x?

version 4.7.1 final

 

[All Astronauts]

Now that 4.7.1 is out I should get along and update this.

[All Astronauts]

Version 3.0.0 submitted, available ???

• 4.7.0 Compatibility Sweep
• NEW! Added to Font Awesome 6 to the Font Awesome chooser. Font Awesome 5 remains as an option.
• A few CSS patches here and there.

If you are using the Font Awesome chooser in KS, you are using FA5. This KS now supports FA6 and at a glance, it is more sizing-compatible with FA4 than FA5 was - that is, some FA5 fonts that swapped in for FA4, the sizes were a little off; that's no longer the case (mostly, have not looked at every FA instance). I'd switch the FA6 but I left the FA5 option in place as some of you might have "stuff" going on.

Couple CSS changes I'd probably only notice.

Uhhh... made sure everything was working? Tested on 4.7.1 107021, PHP 8.0.13. 

Oh, and I forgot to change the version number on the internal language file so the ACP settings area will say 2.2.whatever. Already patched for the next release.

Edited August 27, 2022 by All Astronauts

[OptimusBain]

On 8/17/2022 at 1:30 PM, OptimusBain said:

Good day @All Astronauts

Just wanted to report an issue with Kitchen Sink. 

When I choose to hide the MultiQuote Button, the + multi quote button will not be hidden and the quote icon will disappear. 

There is no way I could find to disable the multi quote button and only leave the quote icon.

is that a known problem?

thanks 

Hello @All Astronauts

I just updated to 3.0.0 and I see the multi quote problem is still there as I explained in a previous comment.

I select Hide Multiquote Button and the multi quote button will not be hidden. The QUOTE button will be hidden instead as you can see in the attachment below.

 

There is no way to disable the multi quote button with the option that you are providing. It will hide the QUOTE button and I will have to have both Multi Quote and Quote buttons.

Thanks a lot

[All Astronauts]

I just woke up, didn't even know it was approved yet 😀. 

Un momento por favor...

[All Astronauts]

I've just toggled on and off (and saved) the settings you have posted up in the off-chance something was spilling over, or I mis-wrapped an if-check in the CSS. I'm not getting this.

Is this happening on the default theme?

Also... toggle off the Bookmark and Tutorial apps when testing. It would not surprise me if we were stepping on each other's toes here. While you are doing that I'll look at the hook more closely and see if that is the hitch here.

[All Astronauts]

It's going to be Bookmark. Specifically, because it stuck itself at the front of the list. I was doing an even/odd thing in the CSS to hide this and appending this button to the front breaks that. This whole area is a hot mess when it comes to multiple third-party hooks and such. Although... I haven't changed this code in ages - maybe there is better targeting available now? Checking. 

EDIT: So now I remember why. The targeting with competing plugins back in the day was hell so I just gave up and did the even odd thing. I can still do this with CSS using nth-of-types now (maybe before too - the mind blurs when you are down some CSS rabbit holes)

I'll submit a new version - gives me a chance to get the version language strings right internally.

Edited August 29, 2022 by All Astronauts

[OptimusBain]

14 hours ago, All Astronauts said:

I've just toggled on and off (and saved) the settings you have posted up in the off-chance something was spilling over, or I mis-wrapped an if-check in the CSS. I'm not getting this.

Is this happening on the default theme?

Also... toggle off the Bookmark and Tutorial apps when testing. It would not surprise me if we were stepping on each other's toes here. While you are doing that I'll look at the hook more closely and see if that is the hitch here.

Thanks a lot. I did toggle them off. When Bookmark and Tutorials are toggled off, it won't work.

If I toggle Kitchen Sink off, then I will see it correctly. That's why I initially contacted you, because when I disabled K. Sink, I will see it correctly. I am using a custom theme that had some colours changed.

14 hours ago, All Astronauts said:

It's going to be Bookmark. Specifically, because it stuck itself at the front of the list. I was doing an even/odd thing in the CSS to hide this and appending this button to the front breaks that. This whole area is a hot mess when it comes to multiple third-party hooks and such. Although... I haven't changed this code in ages - maybe there is better targeting available now? Checking. 

EDIT: So now I remember why. The targeting with competing plugins back in the day was hell so I just gave up and did the even odd thing. I can still do this with CSS using nth-of-types now (maybe before too - the mind blurs when you are down some CSS rabbit holes)

I'll submit a new version - gives me a chance to get the version language strings right internally.

Thanks so MUCH!!!

Edited August 30, 2022 by OptimusBain

[OptimusBain]

On 8/29/2022 at 4:38 PM, All Astronauts said:

It's going to be Bookmark. Specifically, because it stuck itself at the front of the list. I was doing an even/odd thing in the CSS to hide this and appending this button to the front breaks that. This whole area is a hot mess when it comes to multiple third-party hooks and such. Although... I haven't changed this code in ages - maybe there is better targeting available now? Checking. 

EDIT: So now I remember why. The targeting with competing plugins back in the day was hell so I just gave up and did the even odd thing. I can still do this with CSS using nth-of-types now (maybe before too - the mind blurs when you are down some CSS rabbit holes)

I'll submit a new version - gives me a chance to get the version language strings right internally.

I installed the new update you submitted. Tested it with IPS default theme. It looks like it's the Bookmarks application that is causing the issue. Once the Bookmark application is disabled, the multi quote button will be hidden as dictated by Kitchen Sink's settings.

What would you suggest me to do? Contact the Bookmark app developer and tell him something specifically? 

Thanks

[All Astronauts]

Eh, I'm just puttering on various things on the back deck right now (upper 70s, low humidity, nice breeze - yes...) so shoot me a PM with your site (and ACP access which I imagine I've already done with you before) - and I can look closer. At least maybe see what bookmarks is doing there to muck it up.

[All Astronauts]

FYI anyone reading this. It's an unsolvable problem: when something else is in the first position of that post menu.

Alas, the :has CSS selector is still in its infancy and not quite ready for mass adoption yet so... grumble... , I'll eat this and add some derpy Javascript code to deal with this once and for all.

[All Astronauts]

All written up. Even handles them when a new post is made and the post is ajax'd in.

Do I resubmit now? Pretty sure Daniel et.al. are sick of seeing this already. Either way, this will be fixed forever and ever... in the next release.