I see still inconsistant html in 4.3

[steve00]

Noticed there are inconsistant html/css used in different areas

e.g.

The Follow button in topic post uses:

.ipsApp .ipsButton_link.ipsFollow, 
.ipsApp .ipsButton_link.ipsPromote

But in Gallery it uses:

.elGalleryImage .ipsButton.ipsButton_link

Both areas use same html:

class="ipsFollow ipsButton ipsButton_link ipsButton_verySmall"

but for some reason someone decided to add new css for the Gallery image follow button

This is just added more bloat to css file

No doubt there are other areas that have not come across yet

Why do you use two different styles for same item instead of two different styles ?

[steve00]

And another

Original:

ul:not(.ipsMenu_keyNav) .ipsMenu_item:not(.ipsMenu_itemClicked):not(.ipsMenu_itemDisabled) a:hover, 
.ipsMenu_item[data-selected] a, 
.ipsMenu_item[data-selected] span, 
.ipsMenu_item.ipsMenu_hover

In 4.3

ul:not(.ipsMenu_keyNav) .ipsMenu_item:not(.ipsMenu_itemClicked):not(.ipsMenu_itemDisabled) a:not(.ipsMenu_itemInline):hover, 
.ipsMenu_item[data-selected] a, 
.ipsMenu_item[data-selected] span, 
.ipsMenu_item.ipsMenu_hover

Why change it by adding

:not(.ipsMenu_itemInline)

Why not leave alone ?

[bfarber]

7 hours ago, steve00 said:

Why do you use two different styles for same item instead of two different styles ?

I'm sorry, I'm not clear on what you are asking.

6 hours ago, steve00 said:

And another

Original:

ul:not(.ipsMenu_keyNav) .ipsMenu_item:not(.ipsMenu_itemClicked):not(.ipsMenu_itemDisabled) a:hover, 
.ipsMenu_item[data-selected] a, 
.ipsMenu_item[data-selected] span, 
.ipsMenu_item.ipsMenu_hover

In 4.3

ul:not(.ipsMenu_keyNav) .ipsMenu_item:not(.ipsMenu_itemClicked):not(.ipsMenu_itemDisabled) a:not(.ipsMenu_itemInline):hover, 
.ipsMenu_item[data-selected] a, 
.ipsMenu_item[data-selected] span, 
.ipsMenu_item.ipsMenu_hover

Why change it by adding

:not(.ipsMenu_itemInline)

Why not leave alone ?

Because there was a bug, and this change fixed the bug....

We can't leave bugs in place simply so we don't adjust themes in major version upgrades I'm afraid.