Jump to content

Bookmarks - Support Topic


Fosters

Recommended Posts

  • 1 month later...

Error in System Log:

#0 /home/nginx/domains/mycommunity.com/public/system/Member/Member.php(154): IPS\_Session::i()
#1 /home/nginx/domains/mycommunity.com/public/init.php(816) : eval()'d code(64): IPS\_Member::loggedIn()
#2 /home/nginx/domains/mycommunity.com/public/applications/bookmark/sources/Bookmark/Bookmarkable.php(123): IPS\linkedaccounts_hook_la_getAccounts::loggedIn()
#3 /home/nginx/domains/mycommunity.com/public/system/Content/Item.php(3666): IPS\Content\bookmark_hook_content_comment::joins(Object(IPS\forums\Topic))
#4 /home/nginx/domains/mycommunity.com/public/applications/forums/sources/Topic/Topic.php(1861): IPS\Content\_Item->_comments('IPS\\forums\\Topi...', 1, 0, 'post_date desc', NULL, false, NULL, NULL, NULL, false, NULL)
#5 /home/nginx/domains/mycommunity.com/public/system/Content/Search/Elastic/Index.php(885): IPS\forums\_Topic->comments(1, 0, 'date', 'desc', NULL, false)
#6 /home/nginx/domains/adonismale.com/public/system/Content/Search/Elastic/Index.php(245): IPS\Content\Search\Elastic\_Index->resetLastComment(Array, 20656)
#7 /home/nginx/domains/mycommunity.com/public/applications/core/extensions/core/Queue/IndexSingleItem.php(93): IPS\Content\Search\Elastic\_Index->index(Object(IPS\forums\Topic\Post))
#8 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(47): IPS\core\extensions\core\Queue\_IndexSingleItem->run(Array, 0)
#9 /home/nginx/domains/mycommunity.com/public/applications/core/tasks/queue.php(43): IPS\_Task::runQueue()
#10 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(356): IPS\core\tasks\_queue->IPS\core\tasks\{closure}()
#11 /home/nginx/domains/mycommunity.com/public/applications/core/tasks/queue.php(55): IPS\_Task->runUntilTimeout(Object(Closure))
#12 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(255): IPS\core\tasks\_queue->execute()
#13 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(224): IPS\_Task->run()
#14 /home/nginx/domains/mycommunity.com/public/applications/core/interface/task/task.php(62): IPS\_Task->runAndLog()
#15 {main}

 

Link to comment
Share on other sites


I have released a new version addressing this issue:)

9 hours ago, Joel R said:

Error in System Log:


#0 /home/nginx/domains/mycommunity.com/public/system/Member/Member.php(154): IPS\_Session::i()
#1 /home/nginx/domains/mycommunity.com/public/init.php(816) : eval()'d code(64): IPS\_Member::loggedIn()
#2 /home/nginx/domains/mycommunity.com/public/applications/bookmark/sources/Bookmark/Bookmarkable.php(123): IPS\linkedaccounts_hook_la_getAccounts::loggedIn()
#3 /home/nginx/domains/mycommunity.com/public/system/Content/Item.php(3666): IPS\Content\bookmark_hook_content_comment::joins(Object(IPS\forums\Topic))
#4 /home/nginx/domains/mycommunity.com/public/applications/forums/sources/Topic/Topic.php(1861): IPS\Content\_Item->_comments('IPS\\forums\\Topi...', 1, 0, 'post_date desc', NULL, false, NULL, NULL, NULL, false, NULL)
#5 /home/nginx/domains/mycommunity.com/public/system/Content/Search/Elastic/Index.php(885): IPS\forums\_Topic->comments(1, 0, 'date', 'desc', NULL, false)
#6 /home/nginx/domains/adonismale.com/public/system/Content/Search/Elastic/Index.php(245): IPS\Content\Search\Elastic\_Index->resetLastComment(Array, 20656)
#7 /home/nginx/domains/mycommunity.com/public/applications/core/extensions/core/Queue/IndexSingleItem.php(93): IPS\Content\Search\Elastic\_Index->index(Object(IPS\forums\Topic\Post))
#8 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(47): IPS\core\extensions\core\Queue\_IndexSingleItem->run(Array, 0)
#9 /home/nginx/domains/mycommunity.com/public/applications/core/tasks/queue.php(43): IPS\_Task::runQueue()
#10 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(356): IPS\core\tasks\_queue->IPS\core\tasks\{closure}()
#11 /home/nginx/domains/mycommunity.com/public/applications/core/tasks/queue.php(55): IPS\_Task->runUntilTimeout(Object(Closure))
#12 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(255): IPS\core\tasks\_queue->execute()
#13 /home/nginx/domains/mycommunity.com/public/system/Task/Task.php(224): IPS\_Task->run()
#14 /home/nginx/domains/mycommunity.com/public/applications/core/interface/task/task.php(62): IPS\_Task->runAndLog()
#15 {main}

 

 

Link to comment
Share on other sites

  • 3 weeks later...

@Fosters

Error in system log.

URL of page the error occurred on was a profile page

 

invalid_bookmark_item 2866

#0 /home/nginx/domains/mycommunity.com/public/applications/bookmark/extensions/core/StreamItems/Bookmarked.php(58): IPS\_Log::log('invalid_bookmar...')
#1 /home/nginx/domains/mycommunity.com/public/system/Content/Search/Results.php(651): IPS\bookmark\extensions\core\StreamItems\_Bookmarked->extraItems(Object(IPS\Member), 1528573699, NULL)
#2 /home/nginx/domains/mycommunity.com/public/applications/core/modules/front/members/profile.php(257): IPS\Content\Search\_Results->addExtraItems(Array, Object(IPS\Member))
#3 /home/nginx/domains/mycommunity.com/public/system/Dispatcher/Controller.php(96): IPS\core\modules\front\members\_profile->manage()
#4 /home/nginx/domains/mycommunity.com/public/applications/core/modules/front/members/profile.php(73): IPS\Dispatcher\_Controller->execute()
#5 /home/nginx/domains/mycommunity.com/public/init.php(816) : eval()'d code(20): IPS\core\modules\front\members\_profile->execute()
#6 /home/nginx/domains/mycommunity.com/public/system/Dispatcher/Dispatcher.php(152): IPS\core\modules\front\members\hook4828->execute()
#7 /home/nginx/domains/mycommunity.com/public/index.php(13): IPS\_Dispatcher->run()
#8 {main}

 

Link to comment
Share on other sites

On 11/6/2019 at 4:46 AM, Joel R said:

@Fosters

Error in system log.

URL of page the error occurred on was a profile page

 


invalid_bookmark_item 2866

#0 /home/nginx/domains/mycommunity.com/public/applications/bookmark/extensions/core/StreamItems/Bookmarked.php(58): IPS\_Log::log('invalid_bookmar...')
#1 /home/nginx/domains/mycommunity.com/public/system/Content/Search/Results.php(651): IPS\bookmark\extensions\core\StreamItems\_Bookmarked->extraItems(Object(IPS\Member), 1528573699, NULL)
#2 /home/nginx/domains/mycommunity.com/public/applications/core/modules/front/members/profile.php(257): IPS\Content\Search\_Results->addExtraItems(Array, Object(IPS\Member))
#3 /home/nginx/domains/mycommunity.com/public/system/Dispatcher/Controller.php(96): IPS\core\modules\front\members\_profile->manage()
#4 /home/nginx/domains/mycommunity.com/public/applications/core/modules/front/members/profile.php(73): IPS\Dispatcher\_Controller->execute()
#5 /home/nginx/domains/mycommunity.com/public/init.php(816) : eval()'d code(20): IPS\core\modules\front\members\_profile->execute()
#6 /home/nginx/domains/mycommunity.com/public/system/Dispatcher/Dispatcher.php(152): IPS\core\modules\front\members\hook4828->execute()
#7 /home/nginx/domains/mycommunity.com/public/index.php(13): IPS\_Dispatcher->run()
#8 {main}

 

This was removed for the next release.

Link to comment
Share on other sites

  • 2 weeks later...
On 7/10/2019 at 10:10 AM, Fosters said:

There's already a link/button

This button is missing for my member usergroup:

886738255_Screenshot-11_21_201910_25_36AM.png.02534fea81484cd13d7470219b9aa21c.png

But available to my administrator usergroup

1269919761_Screenshot-11_21_201910_25_59AM.png.3e8006ea8f3ae32cf2282be72dcbbb5d.png

Any idea why? Both groups can still remove bookmarks directly from the post. I can't find a per usergroup permission for the "remove bookmark" option.

 

 

EDIT:

Sorry @Fosters, nevermind. This has been resolved. I found the permission. Instead of deleting this post I'll post what I missed in case anyone else has this issue.

I got confused because when I tried to edit the permissions for "Bookmarks" in the Applications section, I got a message that said: "You can control which groups have access to the application by changing the permissions on the modules within the application."  I didn't see that from here, there was an additional dropdown with the bookmark module inside where I could edit the permissions. I created a new usergroup since I initially installed the application, and I didn't realize I needed to grant access there as well as in the main usergroup section.

 

Edited by Hezeber
Link to comment
Share on other sites

  • 1 month later...
  • 1 month later...
1 hour ago, OliverKapunkt said:

Hello @Fosters, I've got an idea for future versions of this addon. In most cases the bookmarks button doesn't really fit to the rest of the theme like here...

booktext.png.8ce1b16318826124c7a2388e6d77001a.png

So how about replacing it with a simple icon like this?

bookmark.png.3b35c8e529e0a1109aaf8aa08fdd91bf.png

Best regards

Isn't this already possible? My board has it exactly there:D 

Will take a look at this tomorrow.

Link to comment
Share on other sites

Hello! After updating the forum to version 4.4.10, some users began to experience errors with access to bookmark pages.
Someone can't even go to the "my bookmarks" page in their profile, someone can't go to page 2 and beyond.

The system log contains the following errors:

Error: Call to a member function canView() on null (0)
#0 /var/www/sp2/system/Helpers/Table/Table.php(489): IPS\bookmark\Bookmark\_Table->getRows(Array)
#1 /var/www/sp2/applications/core/modules/front/members/profile.php(339): IPS\Helpers\Table\_Table->__toString()
#2 /var/www/sp2/system/Dispatcher/Controller.php(96): IPS\core\modules\front\members\_profile->manage()
#3 /var/www/sp2/applications/core/modules/front/members/profile.php(73): IPS\Dispatcher\_Controller->execute()
#4 /var/www/sp2/system/Dispatcher/Dispatcher.php(152): IPS\core\modules\front\members\_profile->execute()
#5 /var/www/sp2/index.php(13): IPS\_Dispatcher->run()
#6 {main}

---------------

invalid_bookmark_item 2714

--------------


Error: Call to a member function canView() on null (0)
#0 /var/www/sp2/system/Helpers/Table/Table.php(489): IPS\bookmark\Bookmark\_Table->getRows(Array)
#1 /var/www/sp2/uploads/template_1_94a9d7649fb9cdbfc784d3516e61a717_global.php(6478): IPS\Helpers\Table\_Table->__toString()
#2 /var/www/sp2/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_core_front_global->globalTemplate('076f60bed3b3d0f...', Object(IPS\bookmark\Bookmark\Table), Array)
#3 /var/www/sp2/system/Dispatcher/Dispatcher.php(172): IPS\Theme\_SandboxedTemplate->__call('globalTemplate', Array)
#4 /var/www/sp2/system/Dispatcher/Standard.php(112): IPS\_Dispatcher->finish()
#5 /var/www/sp2/system/Dispatcher/Front.php(597): IPS\Dispatcher\_Standard->finish()
#6 /var/www/sp2/system/Dispatcher/Dispatcher.php(154): IPS\Dispatcher\_Front->finish()
#7 /var/www/sp2/index.php(13): IPS\_Dispatcher->run()
#8 {main}

--------------------------------

Please tell me, is there a problem on our side or is it a plugin?

Link to comment
Share on other sites

  • 3 weeks later...
On 2/16/2020 at 4:45 PM, Fosters said:

Will take a look at this tomorrow.

For everybody that doesn't want to wait until 'tomorrow', here's a little workaround, quick and dirty as usual 😉

Simply replace the language in your template bookmark -> global -> bookmark -> bookmarkLink with something like this...

<i class="fa fa-bookmark-o fa-2x" style="color:green" aria-hidden="true"></i>

The color is optional, in this case it's for a green theme with larger buttons. Because of the button size, I've added fa-2x, just remove that for normal font size.

Link to comment
Share on other sites

  • 1 month later...
On 4/28/2020 at 8:19 AM, Fosters said:

Huge price drop this week because of Corona craziness...

 

get it while it’s reduced and before the price increases because of 4.5 ( existing customers aren’t affected by this ) 

Thank you so much for reducing the price. This helps so much for those of us who have been unable to work, but want to take advantage of the free time to work on our forums and add new functions. May I ask, how much is the price regularly? $15 is a great price for this. 

UPDATE: I just bought this. When I went to download, there are 2 bookmark files, do I need to install both? Or just one? What are the differences between the two?

Thanks again.

Edited by SC36DC
Link to comment
Share on other sites

9 hours ago, SC36DC said:

Thank you so much for reducing the price. This helps so much for those of us who have been unable to work, but want to take advantage of the free time to work on our forums and add new functions. May I ask, how much is the price regularly? $15 is a great price for this. 

UPDATE: I just bought this. When I went to download, there are 2 bookmark files, do I need to install both? Or just one? What are the differences between the two?

Thanks again.

Sorry, fosters_bookmark_1.6.1.tar is the correct one

 

I think it was 20 or 25$

9 hours ago, Eathanor said:

Is it possible to exclude public bookmarks and allow only private ?

Right now there's only a group permission to allow or disallow private bookmarks, but I t hink that your suggestion makes sense. I'll include this to the next version ( for IPS 4.5 )

Link to comment
Share on other sites


I would be great to be able to move the placement of the bookmark to to  where @OliverKapunkt has suggested, and to allow each member of the forum in settings to place the Bookmark icon where @Phil Këvin has suggested. This way people could get to their bookmarks faster.
 

I managed to change the word Bookmark to an icon, thanks to Oliver's post. I then added a Red Icon to indicate the post has been bookmarked and they could remove the bookmark by clicking the red icon.

00f3d0ccd3b2b6ed373610e30d6a275c.gif.1759829d165be9a96d45049d5b0c8219.gif

This kind of works. 

If I Bookmark a post, then decide to unbookmark it while I'm still on the page, it changes the icon back to normal, but the bookmark is still there if you visit My Bookmarks.

If I bookmark a post, visit another page, then come back to the bookmarked post, unbookmark it, then it does remove it from My Bookmarks.

Hopefully people will not bookmark, then unbookmark it at the same time. It is possible someone will change their mind and do just that. Is there any way to address this?

Thanks.
 

Edited by SC36DC
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...