Dean_ Posted September 9, 2021 Share Posted September 9, 2021 (edited) Just updated - Seems there are still template issues, on modified and default themes. [[Template basicpoints/front/logs/logRows is throwing an error. This theme may be out of date. Run the support tool in the AdminCP to restore the default theme.]] These are on Profile and URL/points links. It doesn't show the logs at all. It seems that it's a PHP8 issue, once changed to 7.4, the errors go. TypeError: method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given in /home2/<SNIP>/public_html/uploads/template_54_09d5381cd6389a5d826715841593342d_logs.php:25 Stack trace: #0 /home2/<SNIP>/public_html/uploads/template_54_09d5381cd6389a5d826715841593342d_logs.php(25): method_exists(Array, 'tableClass') #1 /home2/<SNIP>/public_html/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_basicpoints_front_logs->logRows(Object(IPS\Helpers\Table\Db), Array, Array, 'log_note', NULL, Array) #2 /home2/<SNIP>/public_html/system/Helpers/Table/Table.php(541): IPS\Theme\_SandboxedTemplate->__call('logRows', Array) #3 /home2/<SNIP>/public_html/applications/basicpoints/modules/front/basicpoints/index.php(147): IPS\Helpers\Table\_Table->__toString() #4 /home2/<SNIP>/public_html/system/Dispatcher/Controller.php(101): IPS\basicpoints\modules\front\basicpoints\_index->manage() #5 /home2/<SNIP>/public_html/system/Dispatcher/Dispatcher.php(153): IPS\Dispatcher\_Controller->execute() #6 /home2/<SNIP>/public_html/index.php(13): IPS\_Dispatcher->run() #7 {main} Edited September 9, 2021 by Dean_ SUBRTX 1 Link to comment
Michael.J Posted September 20, 2021 Author Share Posted September 20, 2021 On 9/10/2021 at 1:35 AM, Dean_ said: These are on Profile and URL/points links. It doesn't show the logs at all. Could you please PM me that full logs file? Link to comment
SUBRTX Posted October 12, 2021 Share Posted October 12, 2021 On 9/9/2021 at 11:35 AM, Dean_ said: Just updated - Seems there are still template issues, on modified and default themes. [[Template basicpoints/front/logs/logRows is throwing an error. This theme may be out of date. Run the support tool in the AdminCP to restore the default theme.]] These are on Profile and URL/points links. It doesn't show the logs at all. It seems that it's a PHP8 issue, once changed to 7.4, the errors go. TypeError: method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given in /home2/<SNIP>/public_html/uploads/template_54_09d5381cd6389a5d826715841593342d_logs.php:25 Stack trace: #0 /home2/<SNIP>/public_html/uploads/template_54_09d5381cd6389a5d826715841593342d_logs.php(25): method_exists(Array, 'tableClass') #1 /home2/<SNIP>/public_html/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_basicpoints_front_logs->logRows(Object(IPS\Helpers\Table\Db), Array, Array, 'log_note', NULL, Array) #2 /home2/<SNIP>/public_html/system/Helpers/Table/Table.php(541): IPS\Theme\_SandboxedTemplate->__call('logRows', Array) #3 /home2/<SNIP>/public_html/applications/basicpoints/modules/front/basicpoints/index.php(147): IPS\Helpers\Table\_Table->__toString() #4 /home2/<SNIP>/public_html/system/Dispatcher/Controller.php(101): IPS\basicpoints\modules\front\basicpoints\_index->manage() #5 /home2/<SNIP>/public_html/system/Dispatcher/Dispatcher.php(153): IPS\Dispatcher\_Controller->execute() #6 /home2/<SNIP>/public_html/index.php(13): IPS\_Dispatcher->run() #7 {main} Did this get fixed from the latest update or? I'm about to upgrade my IPS to 4.6.X... @Michael.J Link to comment
Dean_ Posted October 12, 2021 Share Posted October 12, 2021 2 hours ago, SUBRTX said: Did this get fixed from the latest update or? I'm about to upgrade my IPS to 4.6.X... @Michael.J I had to revert to PHP 7.4. SUBRTX 1 Link to comment
Michael.J Posted October 13, 2021 Author Share Posted October 13, 2021 12 hours ago, Dean_ said: I had to revert to PHP 7.4. I'll need a bit more time for PHP8 compatibility. Link to comment
Michael.J Posted October 13, 2021 Author Share Posted October 13, 2021 12 hours ago, Dean_ said: I had to revert to PHP 7.4. I'll need a bit more time for PHP8 compatibility. Link to comment
SUBRTX Posted October 22, 2021 Share Posted October 22, 2021 On 10/13/2021 at 2:33 AM, Michael.J said: I'll need a bit more time for PHP8 compatibility. @Michael.J please read your inbox, thanks! Link to comment
Michael.J Posted October 24, 2021 Author Share Posted October 24, 2021 On 10/22/2021 at 4:31 PM, SUBRTX said: @Michael.J please read your inbox, thanks! Replied. Link to comment
SUBRTX Posted November 29, 2021 Share Posted November 29, 2021 On 10/13/2021 at 2:33 AM, Michael.J said: I'll need a bit more time for PHP8 compatibility. Update ETA? Link to comment
SUBRTX Posted December 4, 2021 Share Posted December 4, 2021 (edited) @Michael.J Hello, when I tried to setup "topic" or "Edit this forum" in the club, error occur I tested on my live site and a clean installed test site. Error log is the same on both site: ArgumentCountError: Too few arguments to function IPS\forums\_Forum::clubForm(), 1 passed in /chroot/home/xxx/xxx/html/init.php(902) : eval()'d code on line 276 and exactly 2 expected (0) #0 /chroot/home/xx/x/html/init.php(902) : eval()'d code(276): IPS\forums\_Forum->clubForm() #1 /chroot/home/xxx/x/html/applications/core/modules/front/clubs/view.php(1545): IPS\forums\basicpoints_hook_forumSource->clubForm() #2 /chroot/home/xxx/x/html/system/Dispatcher/Controller.php(90): IPS\core\modules\front\clubs\_view->nodeForm() #3 /chroot/home/xxx/x/html/applications/core/modules/front/clubs/view.php(120): IPS\Dispatcher\_Controller->execute() #4 /chroot/home/xxx/x/html/system/Dispatcher/Dispatcher.php(153): IPS\core\modules\front\clubs\_view->execute() #5 /chroot/home/xxx/xx/html/index.php(13): IPS\_Dispatcher->run() #6 {main} Edited December 4, 2021 by SUBRTX Link to comment
Michael.J Posted December 5, 2021 Author Share Posted December 5, 2021 On 12/4/2021 at 6:36 PM, SUBRTX said: Hello, when I tried to setup "topic" or "Edit this forum" in the club, error occur Thanks for reporting, I've put up a manual patch until the next update is released here - https://www.devfuse.com/forums/bugs/other-paid-products/basic-points/clubs-add-topic-error-r357/ Ohanzee and SUBRTX 2 Link to comment
SUBRTX Posted December 6, 2021 Share Posted December 6, 2021 7 hours ago, Michael.J said: Thanks for reporting, I've put up a manual patch until the next update is released here - https://www.devfuse.com/forums/bugs/other-paid-products/basic-points/clubs-add-topic-error-r357/ Hello, bad news with this new manual patch, the forum point setting can not be saved I tried to set random number, it all reset to 0. after I replaced the original forumSource.php, my previous setting was restored. Link to comment
Dean_ Posted December 6, 2021 Share Posted December 6, 2021 Any update for PHP8 yet? Only this app is stopping me from upgrading. Link to comment
Michael.J Posted December 6, 2021 Author Share Posted December 6, 2021 17 hours ago, SUBRTX said: with this new manual patch, the forum point setting can not be saved Can you double check the edits performed, not seeing any issues on my end. 9 hours ago, Dean_ said: Any update for PHP8 yet? Only this app is stopping me from upgrading. I haven't updated my test board but I've tried the app on a demo board and I only found 1 issue which I can provide a manual patch for until I've officially updated the app if you would like. Unless you found more issues? Link to comment
SUBRTX Posted December 7, 2021 Share Posted December 7, 2021 8 hours ago, Michael.J said: Can you double check the edits performed, not seeing any issues on my end. Did you set how many points to unlock on a topic on your site? I tested again on my clean installed test site Here what I did, please tell me if any step was wrong I opened public_html-applications-basicpoints-hooks-forumSource.php I searched these lines /** * Set form for creating a node of this type in a club * * @param \IPS\Helpers\Form $form Form object * @return void */ public function clubForm( \IPS\Helpers\Form $form ) { /* Club points disabled? */ if( !\IPS\Settings::i()->basicPoints_club_points ) { return parent::clubForm( $form ); } /* Add tab for default fields */ $form->addTab('basicpoints_club_settings'); /* Show default fields */ parent::clubForm( $form ); replaced them with these /** * Set form for creating a node of this type in a club * * @param \IPS\Helpers\Form $form Form object * @return void */ public function clubForm( \IPS\Helpers\Form $form, \IPS\Member\Club $club ) { /* Club points disabled? */ if( !\IPS\Settings::i()->basicPoints_club_points ) { return parent::clubForm( $form, $club ); } /* Add tab for default fields */ $form->addTab('basicpoints_club_settings'); /* Show default fields */ parent::clubForm( $form, $club ); After that, I went to my test site, using a test account which needs points to unlock topic, but ended up just opened the topic without points needed. So, I went to ACP, found out that unlock point was reset to 0 I changed to 10 but after refresh the page, it went back to 0 again. Link to comment
Dean_ Posted December 7, 2021 Share Posted December 7, 2021 15 hours ago, Michael.J said: Can you double check the edits performed, not seeing any issues on my end. I haven't updated my test board but I've tried the app on a demo board and I only found 1 issue which I can provide a manual patch for until I've officially updated the app if you would like. Unless you found more issues? I’ll check you a PM with all the errors. Thanks 🙏 Link to comment
SUBRTX Posted December 19, 2021 Share Posted December 19, 2021 @Michael.J You didn't reply so I'm assuming the error happened on your test site too? ETA for fix? Link to comment
Michael.J Posted December 21, 2021 Author Share Posted December 21, 2021 On 12/20/2021 at 2:10 AM, SUBRTX said: @Michael.J You didn't reply so I'm assuming the error happened on your test site too? Just tested and not able to reproduce this. Can you PM me admin login details so I can look over this please? Link to comment
SUBRTX Posted December 28, 2021 Share Posted December 28, 2021 On 12/20/2021 at 9:20 PM, Michael.J said: Just tested and not able to reproduce this. Can you PM me admin login details so I can look over this please? Hello, I fixed the issue. I don't know why but my original code in the forumsource.php is different from yours, here is mine: /** * Set form for creating a node of this type in a club * * @param \IPS\Helpers\Form $form Form object * @return void */ public function clubForm( \IPS\Helpers\Form $form ) { try { /* Club points disabled? */ if( !\IPS\Settings::i()->basicPoints_club_points ) { return parent::clubForm( $form ); } /* Add tab for default fields */ $form->addTab('basicpoints_club_settings'); /* Show default fields */ parent::clubForm( $form ); I have this "Try" in my code. So, I added the extra code from the fixed solution, and keep that "try", and my setting didn't reset and club feature is normal /** * Set form for creating a node of this type in a club * * @param \IPS\Helpers\Form $form Form object * @return void */ public function clubForm( \IPS\Helpers\Form $form, \IPS\Member\Club $club ) { try { /* Club points disabled? */ if( !\IPS\Settings::i()->basicPoints_club_points ) { return parent::clubForm( $form, $club ); } /* Add tab for default fields */ $form->addTab('basicpoints_club_settings'); /* Show default fields */ parent::clubForm( $form, $club ); Michael.J 1 Link to comment
Michael.J Posted December 30, 2021 Author Share Posted December 30, 2021 On 12/28/2021 at 2:09 PM, SUBRTX said: Hello, I fixed the issue. I don't know why but my original code in the forumsource.php is different from yours, here is mine: Sorry! I've been developing without the try/catch, so my patch didn't factor that in. Link to comment
Dean_ Posted January 9, 2022 Share Posted January 9, 2022 On 12/6/2021 at 10:27 PM, Michael.J said: Can you double check the edits performed, not seeing any issues on my end. I haven't updated my test board but I've tried the app on a demo board and I only found 1 issue which I can provide a manual patch for until I've officially updated the app if you would like. Unless you found more issues? I've found another issue. This time it's with clubs. Making a new club, you go to add feature (topics) it creates an error.ArgumentCountError: Too few arguments to function IPS\forums\_Forum::clubForm(), 1 passed in /home2/<SNIP>/public_html/init.php(902) : eval()'d code on line 276 and exactly 2 expected (0) #0 /home2/<SNIP>/public_html/init.php(902) : eval()'d code(276): IPS\forums\_Forum->clubForm(Object(IPS\Helpers\Form)) #1 /home2/<SNIP>/public_html/applications/core/modules/front/clubs/view.php(1545): IPS\forums\basicpoints_hook_forumSource->clubForm(Object(IPS\Helpers\Form), Object(IPS\Member\Club)) #2 /home2/<SNIP>/public_html/system/Dispatcher/Controller.php(90): IPS\core\modules\front\clubs\_view->nodeForm() #3 /home2/<SNIP>/public_html/applications/core/modules/front/clubs/view.php(120): IPS\Dispatcher\_Controller->execute() #4 /home2/<SNIP>/public_html/system/Dispatcher/Dispatcher.php(153): IPS\core\modules\front\clubs\_view->execute() #5 /home2/<SNIP>/public_html/index.php(13): IPS\_Dispatcher->run() #6 {main} Do you know when you'll be able to start work on this? I really would like to add the features we've talked about in the past via PM. As updates are slow (everyone has their owns lives). But, if an update is coming, it'll be worth adding as many as you can in one go and produce a nice update for this app. Link to comment
Red Entity Posted January 10, 2022 Share Posted January 10, 2022 How can i give the permission to a group for modify points? Link to comment
Michael.J Posted January 11, 2022 Author Share Posted January 11, 2022 On 1/10/2022 at 12:00 AM, Dean_ said: I've found another issue. This time it's with clubs. Making a new club, you go to add feature (topics) it creates an error. Does your forumSource.php file still have the changes applied? That's what that edit was for and should fix this error. On 1/10/2022 at 12:00 AM, Dean_ said: Do you know when you'll be able to start work on this? Not yet sorry. On 1/11/2022 at 6:55 AM, Red Entity said: How can i give the permission to a group for modify points? Admin CP > Members Tab > Groups > Basic Points. See group permissions for managing app. Link to comment
Dean_ Posted January 12, 2022 Share Posted January 12, 2022 15 hours ago, Michael.J said: Does your forumSource.php file still have the changes applied? That's what that edit was for and should fix this error. All fixed, thank you. 15 hours ago, Michael.J said: Not yet sorry. Is it going to be the first half of this year do you know? As it's holding me back with what I want to do with the community. 😔 SUBRTX 1 Link to comment
Recommended Posts