Jump to content

Rikki/Design: color variables suddenly not being used in 4.1


Recommended Posts

@Rikki: Why do you not utilize theme variables more in your default theme? 

For example, in 4.0 I changed the area background color from #f9f9f9 to #f5f5f5. 

When upgrading to 4.1 you change it to no longer use that variable and instead hardcode the value. In places like this: 

/* Zebra striping */
/* Need to exclude all the other color options here, since they should override the zebra stripes */
.ipsDataList.ipsDataList_zebra .ipsDataItem:not( .ipsDataItem_selected ):not( .ipsModerated ):not( .ipsDataItem_new ):not( .ipsDataItem_success ):not( .ipsDataItem_warning ):not( .ipsDataItem_error ):not( .ipsDataItem_info ):not( .ipsDataItem_status ):nth-child(even) {
    background: #f9f9f9;

Why on earth have you made it so this no longer uses a theme variable here and other places? :( 

And you do this a lot: 

www/themes/1/css/core/admin/core/livesearch.css:                background: #f9f9f9;
www/themes/1/css/core/admin/core/tabs.css:              background: #f9f9f9;
www/themes/1/css/core/admin/core/tabs.css:      border: 10px solid #f9f9f9;
www/themes/1/css/core/admin/core/tabs.css:      background: #f9f9f9;
www/themes/1/css/core/admin/members/restrictions.css:           background: #f9f9f9;
www/themes/1/css/core/admin/system/login.css:                   border-color: transparent transparent transparent #f9f9f9;
www/themes/1/css/core/admin/system/login.css:                   border-color: transparent #f9f9f9 transparent transparent;
www/themes/1/css/core/admin/system/login.css:   background: #f9f9f9;
www/themes/1/css/core/global/framework/data-lists.css:  background-color: #f9f9f9;
www/themes/1/css/core/global/framework/data-lists.css:  background: #f9f9f9;
www/themes/1/css/core/global/framework/data-lists.css:  background: #f9f9f9;
www/themes/1/css/core/global/framework/forms.css:       background: #f9f9f9;
www/themes/1/css/core/global/framework/tables.css:      background: #f9f9f9;
www/themes/1/css/core/global/framework/tables.css:      background: #f9f9f9;
www/themes/1/css/core/global/responsive/menus.css:              background: #f9f9f9;
... etc


Link to comment
Share on other sites


This topic is now archived and is closed to further replies.

  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Create New...