Would be nice if you could make all your code uniform

Have found one sidebar widget in Downloads that uses ipsType_sectionTitle instead of ipsWidget_title

There are also places in other apps that use ipsBox before ipsType_sectionTitle yet other areas have it after that

Makes skinning a pain in the backside

 

Edited November 21, 201410 yr by steve00

I know what you mean steve it  looks a bit of a mare.

You should report any misused CSS styles as a bug, I would think... The default theme should use consistent styles to make sure the suite looks the same throughout...

 

Yeah, it sounds like a bug, you should report it.

Not sure css would be classed as a bug ... if so then be prepared for a lot of reports

Perhaps staff could clarify this ?

I wouldnt call this a bug either Steve,it is just a naming issue.Maybe there is a reason for them doing it in this way.

Sticking the ipsBox outside of everything does make it a nightmare. You either dig into the html and start renaming ipsBox or leave many corners squared. We shouldn't need to dig into any templates as far as I am concerned. Box also over rides section title which really makes things tough. Designing a dark theme tells all these issues. I tried to let staff know of this but well... 

 

And some things are classed ipsBox only so you have to use it or leave it entirely. An example of that would be the users new content box then select events.

Edited November 21, 201410 yr by csm

Can you provide a specific example so that I can see what you are referring to?

e.g. Click downloads and look at sidebar ... top block (Categories) is

ipsType_reset ipsType_sectionTitle

and the other blocks are:

ipsType_reset ipsWidget_title

Will look around for the others (have changed my css so much to change what is not on some pages but is on others that is going to take time to find again)

I'm not exactly sure if this is what he is referring to but I think it is.

I use a dark skin and I'm currently making changes to the default skin to darken the skin up.

Changing this

.ipsBox {
	border-width: 1px;
	border-style: solid;
	border-color: #fff;
	border-radius: 3px;
}

Effects all of this and more

To make it easier for skinning, you should be able to say no box on pages (if you use the wysiwyg editor you get one, if you add a block you get one, sidebars all have the same box and therefor the same colour specified). Pretty much everything is boxed with the same style as above.

Edited November 24, 201410 yr by craigf136

 

PAGES (Records)

Case of ipsBox inside another and you cannot set a css to make one ipsBox do something different to the other

<div class="ipsBox" data-controller="core.global.core.table,core.front.core.moderation" data-resort="listResort" data-baseurl="url_to_forum/index.php?/articles.html/records/&page=1&d=1">
<div class="ipsButtonBar ipsPad_half ipsClearfix ipsClear">
<form data-ipspageaction="" data-role="moderationTools" method="post" action="url_to_forum/index.php?/articles.html/records/&page=1&d=1">
<div class="ipsBox ipsPad">

DOWNLOADS:

Case of no ipsBox outside but it is inside

<ul class="ipsToolList ipsToolList_horizontal ipsClearfix ipsSpacer_bottom">
<h2 class="ipsType_sectionTitle ipsType_reset">What's New</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">There have been no uploaded files yet.</p>
</div>
<h2 class="ipsType_sectionTitle ipsType_reset ipsSpacer_top">Highest Rated</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">No files have been rated yet.</p>
</div>
<h2 class="ipsType_sectionTitle ipsType_reset ipsSpacer_top">Most Downloaded</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">
</div>

But you have ipsBox outside in Forum (Main Page) & Forum Topics

<div class="ipsBox" data-controller="core.global.core.table,core.front.core.moderation" data-tableid="topics" data-resort="listResort" data-baseurl="url_to_forum/index.php?/forum/2-a-test-forum/&page=1">
<h2 class="ipsType_sectionTitle ipsType_medium ipsType_reset ipsClear">1 topic in this forum</h2>
<div class="ipsButtonBar ipsPad_half ipsClearfix ipsClear">

But again not in View Topic Post

<div class="cTopic ipsClear" data-feedid="topic-1" data-lastpage="" data-baseurl="url_to_forum/index.php?/topic/1-welcome/" data-controller="core.front.core.commentFeed,forums.front.topic.view">
<h2 class="ipsType_sectionTitle ipsType_reset ipsType_medium" data-commentcountstring="js_num_topic_posts" data-role="comment_count">

There are more but just posted to give an idea what referring to regarding .ipsBox

Yes, I know can go into all templates and replace the code but it is getting to be a pain

Yes craigf136
and yes steve00

Thank you both of you. There's a few more areas to report but I want to see what happens here first because a issue may get resolved by itself possibly. Believe it or not I've beaten almost everyone of these box areas and got a awesome looking theme,, just a few I can't seem to break the box on  maybe a deeper change is needed possibly too because I had to work my rear off to get where I did. lol..

Other than the issues above I personally think what's been done in 4.0 is just awesome, Get these small tweaks like this worked out and watch out

There's a few more areas to report

​If you have more areas to report then post them (I only posted what had found so far) as the more that are posted then hopefully the more chance of it being looked into whereas if only a few posted then IPS may not think worth worrying about

Another area

PAGES (Records)

You have

<ul class="ipsButtonRow ipsClearfix">

 

GALLERY (Member Albums)

you have:

<ul class="ipsButtonRow ipsPos_right ipsClearfix">

So buttonrow is floating right in one area and not in another

Why not just remove the ipsPos and add float right to the ipsButtonRow ?

There may be other areas doing similar, have not checked elsewhere yet

In main forum view why is there an:

ipsItemStatus ipsItemStatus_large ipsItemStatus_read

but not anything for unread posts or redirect as they only have

ipsItemStatus ipsItemStatus_large 

 

 

Why not just remove the ipsPos and add float right to the ipsButtonRow ?

That would be an inline CSS style. As I understand it, their style guide for 4.0 prohibits inline styles. If you don't want that class in your skin, you'll either need to override it for that element or skin it out.

In main forum view why is there an:

ipsItemStatus ipsItemStatus_large ipsItemStatus_read

but not anything for unread posts or redirect as they only have

ipsItemStatus ipsItemStatus_large 

The one item is read (hence ipsItemStatus_read), while the other two are not. That in itself lets you style unread and read items differently. I can't speak to why there's no indicator for redirects, if that's true.

That would be an inline CSS style. As I understand it, their style guide for 4.0 prohibits inline styles. If you don't want that class in your skin, you'll either need to override it for that element or skin it out.

​I meant add to css file ... in other words do away with ipsPos and add float: right to the buttonrow in stylesheet ?

The one item is read (hence ipsItemStatus_read), while the other two are not. That in itself lets you style unread and read items differently. I can't speak to why there's no indicator for redirects, if that's true.

​Have found that because unread and redirect both have

ipsItemStatus ipsItemStatus_large

then difficult to set icons for unread and redirect whereas if they had their own class (as _read does) then much easier to make changes required for unread and redirect in stylesheet

Hope the above makes more sense ?

Even though bfarber asked for examples it seems no notice was taken as nothing different in Beta 3a

 

There's an open report pointing to this thread in the tracker.  We have to prioritize bugs and we just haven't gotten to this one yet.

I have changed most of the the things brought up here, except Pages issues (because that needs a general sweep through anyway, so I'll tackle those at that time).

Generally, ipsBox should wrap rather than be inside. Feel free to let me know if you find other areas you think are inconsistent.

I have changed most of the the things brought up here, except Pages issues (because that needs a general sweep through anyway, so I'll tackle those at that time).

Generally, ipsBox should wrap rather than be inside. Feel free to let me know if you find other areas you think are inconsistent.

​

Appears still forgot some unless in next beta (I have beta 4b), if so then please disregard this post

DOWNLOADS:

Case of no ipsBox outside but it is inside

<ul class="ipsToolList ipsToolList_horizontal ipsClearfix ipsSpacer_bottom">
<h2 class="ipsType_sectionTitle ipsType_reset">What's New</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">There have been no uploaded files yet.</p>
</div>
<h2 class="ipsType_sectionTitle ipsType_reset ipsSpacer_top">Highest Rated</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">No files have been rated yet.</p>
</div>
<h2 class="ipsType_sectionTitle ipsType_reset ipsSpacer_top">Most Downloaded</h2>
<div class="ipsAreaBackground ipsPad_half">
<p class="ipsType_reset ipsType_light ipsBox ipsPad">
</div>

​and

e.g. Click downloads and look at sidebar ... top block (Categories) is

ipsType_reset ipsType_sectionTitle

and the other blocks are:

ipsType_reset ipsWidget_title

Will look around for the others (have changed my css so much to change what is not on some pages but is on others that is going to take time to find again)

 

No idea if others as not got round to checking those yet as only find them as go through to skin 

 

Edited December 20, 201410 yr by steve00

​I meant add to css file ... in other words do away with ipsPos and add float: right to the buttonrow in stylesheet ?

​Have found that because unread and redirect both have

ipsItemStatus ipsItemStatus_large

then difficult to set icons for unread and redirect whereas if they had their own class (as _read does) then much easier to make changes required for unread and redirect in stylesheet

Hope the above makes more sense ?

​This is kind of late, Steve -- I like what you've been pointing out, but I don't agree with using floats in CSS. Honestly, I feel using floats is bad practice unless it's desperately needed. The whole skin should be so uniform that the floats aren't used rather than having to make a work around using a float if that makes sense.

Otherwise... yes all of these need fixed lol.