CodingJungle Posted August 16, 2013 Share Posted August 16, 2013 File Name: Ad-Blocking Detector Premium File Submitter: CodingJungle File Submitted: 15 Aug 2013 File Category: User and Social Engagement Supported Versions: IP.Board 3.4.x With Ad blocking Detector Premium, You will be able to let members know, that you run ads, and they are vital to running your site. With the premium version, gives several additional options, like hiding content while modal window is being display, disable for groups, detect if no-script or JS has been disabled and hide content, disable cookie for persistent reminders. includes templates and language files to allow easy customization of modal windows and messages that appear. *note: if you have my free version installed, you should remove it before installing this one. **note: demo link will only work if you are a guest, and the cookie option is enable to avoid repeated modals from browsing the site. here to download this file Link to comment Share on other sites More sharing options...
haqzore1 Posted August 19, 2013 Share Posted August 19, 2013 just confirming - this is all allowed by Google? they dont consider this "asking" for clicks (i know its not clicks, just views, but... you know... just making sure)? Link to comment Share on other sites More sharing options...
CodingJungle Posted August 19, 2013 Author Share Posted August 19, 2013 you'd have to check with google to verify if it is okay. it has a wide range of options, from super pervasive to slightly annoying but passive. Link to comment Share on other sites More sharing options...
thompsone Posted September 12, 2013 Share Posted September 12, 2013 Paid, Downloaded, Installed, Configured. Installed Adblock Plus 1.5.5 on Chrome Version 29.0.1547.66 m, restarted browser. Hook doesn't function. No pop-ups, no warnings, no nothing just site sans-ads. Thoughts? Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 Ten days with no response. Is there a reason? Thanks. Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 actually forgot. it is why i've often said a forum is a poor choice for a bug tracker (as i can't set it to send me reminders daily). Have you configured the hook? there are settings for it in system->system settings->hooks->CJ Ad Block Settings. if you have, then i would say its a good possibility that the hook point it uses in your skin doesn't exist, have you tried on the default IPS skin, let me know if it works there, if not, I will set aside some time and come and look at your site. Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 Our default skin is the stock 3.4.5 skin modified so all the hook points would have existed prior to the changes. I'd have to answer yes. You can however provide me with the hook point and I can confirm it's there. Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 <if test="includeLightboxDoReal:|:$this->settings['do_include_lightbox_real']"> {parse template="include_lightbox_real" group="global" params=""} <else /> <script type="text/javascript"> ipb.global.lightBoxIsOff(); </script> </if> its in the globalTemplate, near the bottom of it. Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 I can't remember a version of IPB that wasn't in. That's been around since 2.2.x I think, but yes it's in all my global templates. Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 have you altered the hook file cjadblockdetection_<hash>.php in any way (either directly or in the install xml)? <script type="text/javascript">//<![CDATA[ abp=false; //]]></script> cause going to your site shows this, when a JS file is suppose to be loading there. Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 No the hook file remains intact, I've made no changes. I can't get that error to show on IE, Chrome, or Firefox, so I'm not sure what you're talking about, but it's nice to know it's been in disarray for a couple weeks now. :hmm: Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 without further access, then that is my best guess that some one has altered the hook file, cause those lines do not appear in my code. I've double checked on my own site, and installed on my dev, neither one of produce those lines of code, they produce load javascript line as intended. I would suggest downloading a fresh copy, uninstalling what you have installed, and install from what is in the download zip. Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 Are you running minify? Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 yes, but i do not load the script thru minify, so it shouldn't have any bearing. Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 Well what access do you need? I should get this resolved or remove the hook. (BTW I removed the old hook and installed a new copy of it) Link to comment Share on other sites More sharing options...
CodingJungle Posted September 23, 2013 Author Share Posted September 23, 2013 ACP access with the ability to access, install and remove hooks (also the ability to change settings), and FTP access to the hooks folder, so i can check to see why its creating the hook incorrectly (if that is the case). Link to comment Share on other sites More sharing options...
thompsone Posted September 23, 2013 Share Posted September 23, 2013 PM Inbound Link to comment Share on other sites More sharing options...
Gabriel Torres Posted May 27, 2014 Share Posted May 27, 2014 The Ad Notice title phrase is hardcoded. This should be changed with a variable, so we can easily translate it without having to edit your source code: <h3>Ad Notice</h3> Replace with: <h3>{$this->lang->words['cjadblock_title']}</h3> And add this word to the hook... Link to comment Share on other sites More sharing options...
Gabriel Torres Posted July 12, 2014 Share Posted July 12, 2014 Hi, the hook stopped working for some reason. Still investigating this further. Looking at the page's HTML I can see the javascript code and all its options being correctly loaded. Tested with AdBlock 2.7.7 Link to comment Share on other sites More sharing options...
Dmacleo Posted July 12, 2014 Share Posted July 12, 2014 Hi, the hook stopped working for some reason. Still investigating this further. Looking at the page's HTML I can see the javascript code and all its options being correctly loaded. Tested with AdBlock 2.7.7 ngx_pagespeed issue maybe? I tested it yesterday and it worked for me on apache with pagespeed. Link to comment Share on other sites More sharing options...
Gabriel Torres Posted July 16, 2014 Share Posted July 16, 2014 That was what I thought as well. Right now I have ngx_pagespeed disabled and yet this hook is not working. Forgot to mention that I tried it with "AdBlock Plus": https://adblockplus.org/en/chrome Link to comment Share on other sites More sharing options...
Gabriel Torres Posted July 26, 2014 Share Posted July 26, 2014 Still not working. Removed and reinstalled at no avail. Zero support for a paid hook is unacceptable. Link to comment Share on other sites More sharing options...
Gabriel Torres Posted July 26, 2014 Share Posted July 26, 2014 Hi, I was able to fix it by renaming the .js file to advertisement.js. It seems the developers of AdBlockPlus got smart and created an exception list for jsLoader.js. Changed the hook in order to accomodate the new file name. Working fine now. Thanks. Link to comment Share on other sites More sharing options...
CodingJungle Posted July 26, 2014 Author Share Posted July 26, 2014 Still not working. Removed and reinstalled at no avail. Zero support for a paid hook is unacceptable. sorry been busy in real life, and as well as having serious internet issues. Hi, I was able to fix it by renaming the .js file to advertisement.js. It seems the developers of AdBlockPlus got smart and created an exception list for jsLoader.js. Changed the hook in order to accomodate the new file name. Working fine now. Thanks. k, will take a look at it. Link to comment Share on other sites More sharing options...
Gabriel Torres Posted July 26, 2014 Share Posted July 26, 2014 No worries. I know how it goes... Anyway, I fixed the issue the way I explained, take a look at it whenever you have the time... If you release a new version, don't forget to add the language bit that is hardcoded and that I pointed out on post #18. ;) Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.