Download: (EJ33) ad block Blocker

[Luis Manson]

its ok, great mod, thanks :)

[Divine Forces]

The ability to use linebreaks still doesn't work for me :S (The editor in the ACP is now the big one with bbcode etc but linebreaks still breaks the mod).

[Poison Light]

Uhm, thats weird.
Could you send me a PM with a screenshot of your settings please?

[Divine Forces]

Uhm, thats weird.

Could you send me a PM with a screenshot of your settings please?

http://screencast.com/t/62sEPJ8sI

[Poison Light]

I cant find the problem. I suggest you to toggle the editing mode and add <br /> instead of pressing the enter in the editor.

Can you test that please?

[Divine Forces]

Editing mode and adding br's worked.

[Poison Light]

Ok :)
But im still searching for the problem :P

[Luis Manson]

one question, i wan to track ad blocking, so i wonder where in your code should i add some analytics calls?
something like events: https://developers.google.com/analytics/devguides/collection/gajs/eventTrackerGuide

the JS call is:

_trackEvent(category, action, opt_label, opt_value, opt_noninteraction)

[Poison Light]

You can add in in the adBlock template under

if($.adblock){

Or do you want to add it in a JS file?

[Luis Manson]

not really sure, but i want to have that called only if the users has adblock enabled, maybe just MAYBE along with the user agent to make some stats...dunno just an idea

[Poison Light]

Yes then you need to add it under if($.adblock){

[Luis Manson]

nope...
Error: _trackEvent is not defined

nevermind, i wont die with out it

[Poison Light]

Its a little bit off topic so can you send me your script via PM so i can take a look.

[Luis Manson]

i will think about it, its not THAT important it was for tracking ppl blocking ads with analytics :)

[Poison Light]

i will think about it, its not THAT important it was for tracking ppl blocking ads with analytics :)

Okay, but if you want you can send me a pm to intergate it in my hook.
Im off now :P

[Kandice]

Ok i think add the following things today:

- Hook automatic disabled for Bots

- Options to exclude usergroups.

- Option to show the popup one time in xx minutes

- Option to disable the redirect (So just a nag screen)

Edgar, when you say Hook Automatic Disabled for Bots. Does that mean it automatic Disabled for Guest user too? Because I notice that IPBoard use Bot Group as a Guest. I'm using Bot Group Hook that specify a group for Bot, so I can use use the Exclude Usergroup Exception. But still wondering if this Mod use the same group for Bots and Guest.

[Luis Manson]

now that you ask i can not find references for bot or google in the sources, maybe its disabled for guests...

[Kandice]

If that is true. I think I rather just have the Group Exception there. I can just use Group Bot Hook and add to the exception. This way the hook will not disabled for both Guest and Bot at the same time.

Hope this make sense, thanks.

[Poison Light]

No, it will check if the user agent is a search spider.
So not the guests.

[Poison Light]

now that you ask i can not find references for bot or google in the sources, maybe its disabled for guests...

isset( $result['uagent_type'] ) && $result['uagent_type'] == 'search' && $this->settings['spider_active']

[Luis Manson]

ohhh, you are using IPB's witchcraft!

[Luis Manson]

my users are fast... check this Edgar ;)

+ greasemonkey


+ function removeJS(a)

{

var elmDeleted = document.getElementById("confirmOverlay");

elmDeleted.parentNode.removeChild(elmDeleted);

}


// Wait until the page is fully loaded

window.addEventListener( 'load', function( e ) {


// Remove annoying popups

removeJS('none');


},false);

[dean84]

Edit: nvm, likeit the way it is, anything to annoy those pesky adblock users.

[Poison Light]

my users are fast... check this Edgar ;)

+ greasemonkey


+ function removeJS(a)

{

var elmDeleted = document.getElementById("confirmOverlay");

elmDeleted.parentNode.removeChild(elmDeleted);

}


// Wait until the page is fully loaded

window.addEventListener( 'load', function( e ) {


// Remove annoying popups

removeJS('none');


},false);

Lol i see.
I can do some extra checks :P
Anyway i added an extra check for the search engine bots so i will update the hook soon.
Someone suggestions? :P

[Luis Manson]

if i were really mad i would ban them, how ever i think that maybe the confirmOverlay div could be named dinamycally with, lets say Date(milliseconds) or some dinamic/random string... that would make their work a bit harder...