Marcher Technologies Posted July 9, 2012 Share Posted July 9, 2012 Thank you 98e932d8916c326e1f53da8e203eeec8 both for finding this, and making me aware of it... .5.1->.5.2 is a simple re-upload of the files and done... seems authentication requests were needlessly being fired for login methods not this one... couple of code changes appears to avoid this. Link to comment Share on other sites More sharing options...
jasperjames Posted July 13, 2012 Share Posted July 13, 2012 Thank you 934c39e6d5c24660dbab02b058b2e85a both for finding this, and making me aware of it... .5.1->.5.2 is a simple re-upload of the files and done... seems authentication requests were needlessly being fired for login methods not this one... couple of code changes appears to avoid this. Hi Marcher, I am still having an issue where the Gmail user gets redirected to Google to verify everytime, rather than just once. I have installed the latest version of Sign in with Google fresh on my board which is also up to date, 3.3.4. I'm not sure if Google have changed something with OAuth 2.0. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 13, 2012 Share Posted July 13, 2012 Hi Marcher, I am still having an issue where the Gmail user gets redirected to Google to verify everytime, rather than just once. I have installed the latest version of Sign in with Google fresh on my board which is also up to date, 3.3.4. I'm not sure if Google have changed something with OAuth 2.0. did you configure the system setting for this? it defaults on install to the described behaviour, but is configurable... :unsure: Link to comment Share on other sites More sharing options...
jasperjames Posted July 13, 2012 Share Posted July 13, 2012 Hi Marcher, Thanks for your reply, I can't see any setting relating to this under the Log In Authentication Manager. Can you tell me where to set this? Many thanks! Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 13, 2012 Share Posted July 13, 2012 Hi Marcher, Thanks for your reply, I can't see any setting relating to this under the Log In Authentication Manager. Can you tell me where to set this? Many thanks! ACP->System->System Settings->Social Media and Sharing->Google Login Prompt Type Link to comment Share on other sites More sharing options...
jasperjames Posted July 13, 2012 Share Posted July 13, 2012 Ah ha! Set to automatic and that's done it, thank you. Link to comment Share on other sites More sharing options...
knaleffect Posted July 14, 2012 Share Posted July 14, 2012 Redirect URIs http://www.jorum.nl/interface/board/google.php http://www.jorum.nl/interface/board/linkgoogle.php https://www.jorum.nl/interface/board/google.php https://www.jorum.nl/interface/board/linkgoogle.php Javascript origins http://www.jorum.nl This is what I have, what is wrong with it? I have still the error. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 14, 2012 Share Posted July 14, 2012 [color=#282828][font=helvetica, arial, sans-serif]Redirect URIs[/font][/color] http://www.jorum.nl/interface/board/google.php http://www.jorum.nl/interface/board/linkgoogle.php https://www.jorum.nl/interface/board/google.php https://www.jorum.nl/interface/board/linkgoogle.php Javascript origins http://www.jorum.nl This is what I have, what is wrong with it? I have still the error. Javascript origins are moot... your domain factually have a www in use? Google is evil picky here. Link to comment Share on other sites More sharing options...
Bartek Posted July 22, 2012 Share Posted July 22, 2012 1) Minor: When someone has registered through ex. facebook there is small FB icon near his email in userlist in ACP - why not in this case? 2) After install I don't have "Sign with google" button at pop-up login only at login page. 3) Is there any way to suggest only display user name (like with others ex. facebook sign in)? User would change it but by default field is filed with his Google name? Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 22, 2012 Share Posted July 22, 2012 1) Minor: When someone has registered through ex. facebook there is small FB icon near his email in userlist in ACP - why not in this case? 2) After install I don't have "Sign with google" button at pop-up login only at login page. 3) Is there any way to suggest only display user name (like with others ex. facebook sign in)? User would change it but by default field is filed with his Google name? 1) I never even noticed that icon... thus never hooked it in or saw the need.... will hook it in with spare time. 2) You should... did you check the stock skin to see if the skinner had a play with hook points? 3) I can look around with doing such... but... they use a method to create the member there I cannot due to bugginess here as a direct result... i'm calling IPSMember::create directly... the last thing anyone needs is a user with no display name when I factually have that data, for now they can change this from their UCP, if allowed, and you may choose what of the retrieved data is used.... Is not like facebook connect where you can have a bevy of users with no display name 'incomplete' as a result of how it works and I personally think that is a better route. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 23, 2012 Share Posted July 23, 2012 [color=#282828][font=helvetica, arial, sans-serif]Redirect URIs[/font][/color] http://jorum.nl/interface/board/google.php http://jorum.nl/interface/board/linkgoogle.php https://jorum.nl/interface/board/google.php https://jorum.nl/interface/board/linkgoogle.php This is what I have, what is wrong with it? I have still the error. visited your site... remove the www, your domain does not use one.... the above should work fine. Link to comment Share on other sites More sharing options...
FXAff Posted July 28, 2012 Share Posted July 28, 2012 Brilliant plugin. However, after confirming the authentication, I get the following message: "As this is the first time you've logged in, we require just a few more details before we can proceed and nothing else on the screen." Would you be kind enough to let me know how to fix this? My registration form requires some custom fields. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 28, 2012 Share Posted July 28, 2012 :mad: You... aren't kidding are you. Great... for once it would be nice for IPB to sanely handle cases like this with external login methods instead of a blank bloody screen(I am not the one making that occur). Will see what can be done. Link to comment Share on other sites More sharing options...
FXAff Posted July 28, 2012 Share Posted July 28, 2012 Hope you aren't pissed, are you? Should I be checking this out with IPB support? I'm 50% sure they'll tell me since this is an external plugin they can't do much about it. But let me know either ways. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 28, 2012 Share Posted July 28, 2012 Hope you aren't pissed, are you? Should I be checking this out with IPB support? I'm 50% sure they'll tell me since this is an external plugin they can't do much about it. But let me know either ways. I'm upset with how IPB handles this for any external login method not their own.... this simply should not occur, sanity would dictate if the admin requires custom fields, something spec to the install, the user, where that 'blank' Page is should show the inputs for the required missing information. Instead, it does that, for any reg method that attempts to auto-fill the info in that situation where you have required fields. :sick: Looking at hooking in to fix... but does any login method not IPB internal actually give the inputs for those fields? Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 28, 2012 Share Posted July 28, 2012 Hope you aren't pissed, are you? Should I be checking this out with IPB support? I'm 50% sure they'll tell me since this is an external plugin they can't do much about it. But let me know either ways. Could bypass them in the create call., that would be the cheap/quick fix.... Not at all certain that is desirable, will look at hooking in to add the actual not provided inputs(thx IPB, swell, this isn't even loaded data-wise here -.-).. until then, the cheap fix would be /admin/sources/loginauth/google/auth.php... right near the bottom find: TRUE ); $this->return_code = 'SUCCESS'; add another parameter to the create call: TRUE, TRUE ); $this->return_code = 'SUCCESS'; Save and re-upload the file. Link to comment Share on other sites More sharing options...
FXAff Posted July 29, 2012 Share Posted July 29, 2012 Made changes as mentioned. Still the same. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted July 29, 2012 Share Posted July 29, 2012 Made changes as mentioned. Still the same. if you are testing with the same user, it would.... once IPB does that....... you have to nuke(delete) the IPB account or fill in their required field data(from acp) to unlock them. Note, I Speak of the same google account. Link to comment Share on other sites More sharing options...
The Nomad Posted August 10, 2012 Share Posted August 10, 2012 MT, I'm the sort of guy you dread "the clueless" :cry: Below is how my client ID appears. However when I have set up all the fields within the ACP nothing materializes on the 'create login' I'm not sure if I should have added java field with anything ? also the only place I add my domain is in the redirect. Any suggestions please ? Link to comment Share on other sites More sharing options...
Marcher Technologies Posted August 10, 2012 Share Posted August 10, 2012 is the login method enabled and the settings in IPB for this hook filled out? also, ware any fubs on https vs http and www vs not on the redirect uri, and yes, this uses server-side code, not javascript, redirect URI's is the correct field. Link to comment Share on other sites More sharing options...
Dmacleo Posted August 10, 2012 Share Posted August 10, 2012 missing one redirect uri there, interface/board/linkgoogle.php needed too Link to comment Share on other sites More sharing options...
The Nomad Posted August 10, 2012 Share Posted August 10, 2012 Thanks for both replies :thumbsup: MT.. Yes I missed the last part in login management :cry: .. now all appears to be well. I have an alias gmail account and worked fine. Now for the mystery, to me anyway. When I started I actually started with 'generate' new key and not "create a server key" I'm afraid I got lost on that one and hence the 'generate new key' I then followed the instructions and ended up with the Diagram above. This may be the reason I am missingthe[color=#282828][font=helvetica, arial, sans-serif]interface/board/linkgoogle.php needed too[/font][/color] I certainly filled in all the fields that were in front of me, so not quite sure where I had to put that. Can you foresee any problems with the way I completed it ? I have attached the 'create a new server key' (this was what threw me) what exactly do I fill in there ? Sorry to be long winded and really appreciate the time taken to answer. I do have another forum I will be adding this to so not quite sure whether I will need to know about the " create new server key" to add another. Many thanks again Link to comment Share on other sites More sharing options...
Marcher Technologies Posted August 10, 2012 Share Posted August 10, 2012 umm, the first screen shot posted looks more correct than..... whatever screen that is....(note to self, update the instructions for the user not having a g+ account, google is being sneaky devious with the UI). Redirect URI's should accept more than 1 URL. Link to comment Share on other sites More sharing options...
NickDorazio Posted August 24, 2012 Share Posted August 24, 2012 Thank you 90f749a08798faa726341647f3081af8 both for finding this, and making me aware of it... .5.1->.5.2 is a simple re-upload of the files and done... seems authentication requests were needlessly being fired for login methods not this one... couple of code changes appears to avoid this. For anyone that didn't catch the meaning of this, I believe the author is describing an instance in which a person who creates a new member using some other method--the normal IPB "create user" button for example--and who is then redirected to the Google sign-in after he completes his registration instead of to the normal IPB sign-in page. I was experiencing this problem but then after upgrading to 5.2 it went away. Thank you for the excellent plug-in. Link to comment Share on other sites More sharing options...
Marcher Technologies Posted August 26, 2012 Share Posted August 26, 2012 For anyone that didn't catch the meaning of this, I believe the author is describing an instance in which a person who creates a new member using some other method--the normal IPB "create user" button for example--and who is then redirected to the Google sign-in after he completes his registration instead of to the normal IPB sign-in page. I was experiencing this problem but then after upgrading to 5.2 it went away. Thank you for the excellent plug-in. :sad: :sick: I never got to see the results of that(just was made aware of the needless calls and soundly fixed it), but that is very very bad, I do apologize for any inconvenience that had caused. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.