LastDragon Posted July 6, 2010 Share Posted July 6, 2010 BUG: #23898 Updating status to: Not a Bug Please re-post this in the peer-to-peer forums for further assistance. After use buildInDev.php for a new skin all master templates contains "<!--no data in this master skin-->" and after set 'inDevDefault' in 'masterMap.php' to 'newskin' we have a blank page instead of forum... Maybe I'm doing something wrong? Link to comment Share on other sites More sharing options...
LastDragon Posted July 7, 2010 Author Share Posted July 7, 2010 1) Create a new skin in ACP (key = test, parent = none | IP.Board) 2) Enable IN_DEV 3) Add this code to /cache/skin_cache/masterMap.php: // Skin: test $REMAP['masterKeys'][] = 'test'; $REMAP['export'] += array( 13 => 'test', ); $REMAP['templates'] += array( 'test' => 'master_skin_test', ); $REMAP['css'] += array( 'test' => 'master_css_test', ); $REMAP['images'] += array( 'test' => 'master', ); 4) Set $REMAP['inDevDefault'] to 'test' 5) Use buildInDev.php to generate master directories Result: all master templates contains "<!--no data in this master skin-->" + empty _replacements.php + empty master_css_test. Example /cache/skin_cache/master_skin_test/skin_global.php: <?php /** * Master skin file * Written: Wed, 07 Jul 2010 03:59:11 +0000 */ class skin_global_1 extends output { //=========================================================================== // Name: defaultHeader //=========================================================================== function defaultHeader() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: forum_jump //=========================================================================== function forum_jump($html) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: globalTemplate //=========================================================================== function globalTemplate($html, $documentHeadItems, $css, $jsModules, $metaTags, $header_items=array(), $items=array(), $footer_items=array(), $stats=array()) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: shareLinks //=========================================================================== function shareLinks($links, $title='', $url='', $cssClass='topic_share left') { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: signature_separator //=========================================================================== function signature_separator($sig="") { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: topic_popup //=========================================================================== function topic_popup($topicId='', $seoTitle='') { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: user_popup //=========================================================================== function user_popup($memberid=0, $seoName='') { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: userInfoPane //=========================================================================== function userInfoPane($author, $contentid, $options) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: paginationTemplate //=========================================================================== function paginationTemplate($work, $data) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: quickSearch //=========================================================================== function quickSearch() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeVars //=========================================================================== function includeVars() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: include_highlighter //=========================================================================== function include_highlighter($load_when_needed=0) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: include_lightbox //=========================================================================== function include_lightbox() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: include_lightbox_real //=========================================================================== function include_lightbox_real() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeCSS //=========================================================================== function includeCSS($css) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeFeeds //=========================================================================== function includeFeeds($documentHeadItems) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeJS //=========================================================================== function includeJS($jsModules) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeMeta //=========================================================================== function includeMeta($metaTags) { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } //=========================================================================== // Name: includeRTL //=========================================================================== function includeRTL() { $IPBHTML = ""; //--starthtml--// $IPBHTML .= <<<EOF <!--no data in this master skin--> EOF; //--endhtml--// return $IPBHTML; } } ?> This is not a bug? Link to comment Share on other sites More sharing options...
LastDragon Posted July 7, 2010 Author Share Posted July 7, 2010 Hm... This is a buildInDev.php errors: Templates: foreach( $master as $m ) { $dir = ( $m == 'root' ) ? 'master_skin' :'master_skin_' . $m; $skinFunctions->writeMasterSkin( $m, $dir ); $this->_print( "PHP templates written for $m" ); } $m сontains string skin key (root, xmlskin etc.), but writeMasterSkin requires skin id (number - 0, 1, 2...). Replacements and CSS have the same error. In this version (3.1.0 and 3.1.1) impossible to create your own style... Thanks guys, great version.Looks like my next project will be on another board software - tired of correcting your mistakes. Link to comment Share on other sites More sharing options...
bfarber Posted July 7, 2010 Share Posted July 7, 2010 My first question is - why are you creating a new skin IN_DEV? You can skin just fine using the normal ACP tools without IN_DEV, so I'm curious what it is you are trying to do exactly? Link to comment Share on other sites More sharing options...
Management Matt Posted July 7, 2010 Management Share Posted July 7, 2010 IN_DEV is really only for IPS developers. We allow others to use it with the understanding that its not officially supported and probably won't work out of the box as we have a lot of things tied to SVN, etc. Link to comment Share on other sites More sharing options...
LastDragon Posted July 7, 2010 Author Share Posted July 7, 2010 My first question is - why are you creating a new skin IN_DEV? You can skin just fine using the normal ACP tools without IN_DEV, so I'm curious what it is you are trying to do exactly? 1) Because edit templates through the ACP is stupidity... 2) ACP tools not working, see #23983 (tested on your demo version). 2) All my projects use svn and all project data save in svn 4) I always use IN_DEV mode 5) I not use ACP* IN_DEV is really only for IPS developers. We allow others to use it with the understanding that its not officially supported and probably won't work out of the box as we have a lot of things tied to SVN, etc. In the documentation you recommend this method - http://community.invisionpower.com/resources/documentation/index.html/_/tutorials/skinning/editing-html-and-css-outside-the-admin-cp-r170 Guys, I really like IPB3, and I especially like that all* actions can be done without ACP. I think most developers are too much. So I do not agree that IN_DEV need only to you. In addition, my current project will help you sell a license, so I do not understand why you do not want to correct errors critical for developers... I think you understand that the more time I spend on correcting your mistakes, the less I desire to use your product in the future. In any case, this is a error - empty master files should not be created.* - for myself, I created ant script that implements all the actions without ACP (more info, EN)P.S. Incidentally, I was upset when was released unfinished beta version (3.1.0 and 3.1.1 - is not release, releases may not contain so many mistakes, especially in IN_DEV mode). P.P.S. It seems that IN_DEV mode you do not use. I do not know how else to explain these errors. P.P.P.S. Sorry... Link to comment Share on other sites More sharing options...
bfarber Posted July 7, 2010 Share Posted July 7, 2010 We use IN_DEV mode and have no issues reimporting and exporting templates (with regards to your "P.P.S."). This is one of the limiting factors. As Matt said, we allow anyone to use it, but the developer tools work fine for us, so it's hard to justify spending tons of time on tools that a very very small fraction of our customers use. Link to comment Share on other sites More sharing options...
Wolfie Posted July 7, 2010 Share Posted July 7, 2010 Not really sure what this guy is doing but with regards to IN_DEV mode, I enable it quite often, only disabling it when I need to recache a skin or something else along those lines because I'll get a memory error. But I just disable, repeat the action and problem is gone. For editing skins, I've never seen a benefit to having IN_DEV enabled, not even for those three Ricki buttons up top. Link to comment Share on other sites More sharing options...
LastDragon Posted July 8, 2010 Author Share Posted July 8, 2010 For editing skins, I've never seen a benefit to having IN_DEV enabled, not even for those three Ricki buttons up top. Not editing, creating a new skin + application (one project). And I do not feel the pleasure of editing the templates in the ACP - it is very uncomfortable - hard to look at the code, there is no syntax highlighting, there is no autocompletion (for CSS), it works slowly with large files... We use IN_DEV mode and have no issues reimporting and exporting templates (with regards to your "P.P.S."). This is one of the limiting factors. As Matt said, we allow anyone to use it, but the developer tools work fine for us, so it's hard to justify spending tons of time on tools that a very very small fraction of our customers use. You and Matt underestimate IN_DEV mode - it is very useful especially for third-party developers, and through them - for all users, and for you (the more useful mods, the more users) Now, why is it useful: you can automate all steps in the development of applications, hooks and skins. As already said, this is what I did (because I'm too lazy to perform the same actions in ACP) and instead of finding the right buttons in the ACP when creating a release application, the following occurs (a small PR;)): (I think the translation is not needed?) Link to comment Share on other sites More sharing options...
Wolfie Posted July 8, 2010 Share Posted July 8, 2010 Okay I'm sure that my lack of PHP knowledge and such will be flooding the topic here with this question but.. What does IN_DEV have to do with using that program? :blink: Link to comment Share on other sites More sharing options...
LastDragon Posted July 8, 2010 Author Share Posted July 8, 2010 This is not a program (in the video shown eclipse, but it does not matter in this case) - this is ant script that calls a PHP script that calls the appropriate methods of IPB controllers (they available only in IN_DEV mode). For example, target "project.rebuild" fully equivalent to calling: Rebuild Master HTML From PHP Caches Rebuild Master CSS From Disk Files Rebuild Master Replacements From Disk File Developer's Language Cache Import -> Select the application language files to import Link to comment Share on other sites More sharing options...
Management Matt Posted July 8, 2010 Management Share Posted July 8, 2010 I'll look into it. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.