June 8, 2010 in Feedback
Just a suggestion, but I think it's a good one: replace all 'private' properties and methods with 'protected'
As I just started to hack the IPBcode, trying to add new features, I already ran into a dead end because of the 'private' modifier.
Generally, protected is much better choice when you have a possibility of someone else writing some addon or mod. It's also much better for writing test cases since it is difficult to write a test for the private methods.
I agree and have been slowly updating them as people have made specific requests. If there are any specific methods you want opened up let me know.
Could you do this to the ACP log viewing scripts, Brandon? adminlogs.php specifically is almost entirely private.
Unless you'd like to add this to the remove() function yourself:
$user = $this->DB->buildAndFetch( array( 'select' => 'name', 'from' => 'members', 'where' => 'member_id=' . intval($this->request['mid']) ) );
$this->registry->getClass('adminFunctions')->saveAdminLog( sprintf( "Removed %s's admin logs", $user['name'] ) );
Done for adminlogs and modlogs.
This topic is now archived and is closed to further replies.
Started 20 hours ago
Started 18 hours ago
Started 14 hours ago