Jump to content

Do links with commas work?


DiskusjonNO

Recommended Posts

As I said, I could go either way. But this example is still valid:

http://domain.com/script.php?var=value&delim=,

The comma is the last character, yet in this case it should be part of the URL. What about this example:

http://domain.com/script.php?var1=value1&var2=, blah blah blah

With this one "var2" could be blank and the comma is not part of the URL. The two are programatically identical to each other, yet both have a different context. I'm sure there are other examples as well. Really I'd be more concerned with this:

http://www.domain.com/script.php?var[one]=value&var[two]=value



http://www.domain.com/script.php?var[one]=value&var[two]=value

The above breaks because square brackets are used in bbcode.

Link to comment
Share on other sites

  • Replies 53
  • Created
  • Last Reply

Not sure what you are trying to prove here, at the end of the day many URL's contain commas including links from Google, The Times, etc. and they all break when cut and pasted into IPB when they contain commas - FACT.

They work fine in older versions of IPB and VB amongst others - FACT

All we are asking is that IPB drop the idea that a comma might be part of a sentence made my a user who has made a grammatical mistake and show them as links.

Link to comment
Share on other sites


It's a valid solution, so use it or stop complaining


That has nothing to do with me. I would use it, allright. But I'm an admin and mod of an IPB board and so I know users in general: They DO NOT use the BBCode solution. That means for the staff of the site: tidy up all the links with commas, so that they function. The expectation of the users to parse links with commas outweighs by far some bad spellers, who can't but a space after a comma. We just want the solution of IPB.Board 2, 3.0.0 & 3.0.1 back. Or an otherwise compromise like wolfie proposed: "parsing commas unless it's the last character" - at least that will catch most of the links with commas and would be a proper fulfillment of the designated function of the parsing engine. The current solution is a burden in every way and that it still exists seems to stem from the unreasonableness of the developers. The current solution was a mistake, it is as easy as that. I don't see the problem or shame in just accepting that. Please stop this ridiculous walk on eggshells!
Link to comment
Share on other sites

For anyone wanting to change the way their board handles it, here is what you do:

* Open admin/sources/classes/bbcode/core.php
* Find (around line 1481) the regular express after "Auto parse URLs".
* Inside you'll find this small bit of code in the expression: [^,\s\<\[]
* Remove the comma.
* Save.

The only problem is that it will parse a comma even if it's at the end of the URL. ie, if the last character is a comma, it still gets parsed.

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

  • Recently Browsing   0 members

    • No registered users viewing this page.

×
×
  • Create New...