Jump to content

Bottom Bar 1.0.1


Nuclear General

Recommended Posts


Five minutes after I installed it I topic popped up saying stop turning this into FB. I realize some users arnt gona like this and that's why the Hide bottom bar is in the user control panel.


Is it possible to have a "Hide bottom bar" button on the bar itself? When clicking it the user will get a msg saying To reinable this please go to "My Settings > Bottom Bar"



I can write up a tutorial to have a button on the bar to switch it off if you want.


Is it also possible to have it off by default?



Try this for default off.
Go to FTP, open /admin/applications_addon/other/bottombar/usercpForms.php,
Find in this file:


$_hide        = $this->request['hide_bottombar'] ? 1 : 0;

Change to:


$_hide        = $this->request['hide_bottombar'] ? 0 : 0;



And see if that helps with default off.


@ Wolfie: **They turned of Neg Reps. Ya happy bro! :lol:**

Link to comment
Share on other sites

  • Replies 239
  • Created
  • Last Reply

@ Wolfie: **They turned of Neg Reps. Ya happy bro! :lol:**



Yeah I noticed. I only hope that IPS looked back on that horrible thread and realized that the system was indeed being abused (overall). It is rather sad to look at someone upset about trying to cancel an order and they get a huge negative rep for it. It's almost like the community saying, "Once you're part of us, you may not leave without suffering."
Link to comment
Share on other sites


If it's off by default, then many won't even know it's there, making it rather useless.



We'll I'm coming from more of a, I don't want to shove almost trivial items in my users face. If someone likes it and finds it useful then hurry for them. But I would like this more of a hidden option if anything. (not 100% sure if Ill use it, after them errors are fixed, but Nuclear General post does show some promise of stubborn users.)

I can write up a tutorial to have a button on the bar to switch it off if you want.



That would be really cool if you could.

At first I was excited about this until I really used it.

As one of my moderates said "the bar itself is pretty much a UI disaster for most boards, it provides the same non-vital functions that are provided elsewhere at the site while taking up screen real estate"
Maybe a real time PM system for your friends would make this seem more accepted into communities.

On a side note, think it would be possible to make a bar like this but have the Mod Tools in it.
Link to comment
Share on other sites


I haven't tested an upgrade with it yet, but I did notice that it won't do an upgrade process because you haven't updated the versions.xml file with a new version in the list. It's still at 1.0 100. So an upgrade is not feasible.




Ok, so the settings are missing, and the upgrade routine (version history). Sounds like all then? Hopefully? lol


Speech Bubbles + Images? That is Old School



Here is the latest and new way to do them with Progressive Enhancement


[url="http://nicolasgallagher.com/progressive-enhancement-pure-css-speech-bubbles/"]Read More About CSS Speech Bubbles in this Awesome Article![/url]




...[snip]...




That's great and all for browsers that support it. Not all browsers support it however. Basically, no versions of IE do.



Hey Brandon, you should possibly add the subpanel-ul-wrapper to the PMPanel as well, just in-case some people wanna change the number of PMs that show up. Just a suggestion. :)




I thought about that (did at first) but since I hardcoded a limit on the list, don't think it's necessary. It's an extra DOM element, firstly, and if you are already modifying your PM limit in the source files, you can make the quick edit in the skin file as well in my mind.



Not quite. Another minor issue, just want to make sure it's noticed, quoted below.




Just to clarify.. I had a post marked as a favorite. Uninstalled and reinstalled. I know that 'favorite' is now forgotten, but it still says that I have a favorite post, but nothing is listed when I click on the star.




That's not something I'm going to fix. ;)

But if it bugs you, you can add a favorite and delete it. Anytime you delete a favorite, it recounts your favorites for you.



When I login I get the following error when Bottom Bar is installed.




Warning: Cannot modify header information - headers already sent by (output started at .../forums/admin/applications_addon/other/bottombar/sources/hooks.php:79) in .../forums/admin/sources/classes/output/formats/html/htmlOutput.php on line 93 Warning: Cannot modify header information - headers already sent by (output started at .../forums/admin/applications_addon/other/bottombar/sources/hooks.php:79) in .../forums/admin/sources/classes/output/formats/html/htmlOutput.php on line 96 Warning: Cannot modify header information - headers already sent by (output started at .../forums/admin/applications_addon/other/bottombar/sources/hooks.php:79) in .../forums/admin/sources/classes/output/formats/html/htmlOutput.php on line 104 Warning: Cannot modify header information - headers already sent by (output started at .../forums/admin/applications_addon/other/bottombar/sources/hooks.php:79) in .../forums/admin/sources/classes/output/formats/html/htmlOutput.php on line 105 Warning: Cannot modify header information - headers already sent by (output started at .../forums/admin/applications_addon/other/bottombar/sources/hooks.php:79) in .../forums/admin/sources/classes/output/formats/html/htmlOutput.php on line 109

Warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in .../forums/admin/applications_addon/other/bottombar/sources/hooks.php on line 79











I have also noticed that if "Allow users to choose skins?" is sent to NO the bar does not display.


Five minutes after I installed it I topic popped up saying stop turning this into FB. I realize some users arnt gona like this and that's why the Hide bottom bar is in the user control panel.
Is it possible to have a "Hide bottom bar" button on the bar itself? When clicking it the user will get a msg saying To reinable this please go to "My Settings > Bottom Bar"

Is it also possible to have it off by default?



I'll look into the warning.

As for "allow users to choose skins" - is anyone else noticing that?

And lastly, I won't be personally adding an option to the bar itself to hide it. Takes 2 seconds to click to your usercp to shut it off. There's a point where you just have to say "ok, if it bothers you that much, take a couple seconds out of your day to go to this page to do something about it". :P The option is at least there now if they would like to shut it off. :)
Link to comment
Share on other sites


(not 100% sure if Ill use it, after them errors are fixed, but Nuclear General post does show some promise of stubborn users.)



Not quite sure what that means... but I'll take it as a complement. :lol:


And lastly, I won't be personally adding an option to the bar itself to hide it. Takes 2 seconds to click to your usercp to shut it off. There's a point where you just have to say "ok, if it bothers you that much, take a couple seconds out of your day to go to this page to do something about it". :P The option is at least there now if they would like to shut it off. :)



I'd have to agree with that section there. It only takes 2 clicks and a mere 10 seconds, if that, to switch it off.
Link to comment
Share on other sites


Ah, fantastic. :rolleyes:



Will export the settings this evening and update the package. It shouldn't impact anything in the mean time (the setting allows you to make the bar 100% width), and you should be able to import the settings separately when I export them this evening. If that's the only issue, not a big deal.




Has this been updated again now? Are we good to go?
Link to comment
Share on other sites

Yes, I just tried it on my forums and if I select it so the users can't choose their skin, then the bar disappears. Enable that option again and the bar shows up.



Same here, I can't use this addon because I need to disable this option on my board "Allow users to choose skins?".
Can you modify the code in order to work with the "Allow users to choose skins?". disabled?
Link to comment
Share on other sites

I'm guessing the problem is simply the hook point I chose (which is largely irrelevant, since CSS forces the bar to the bottom of the screen anyways). I'll take a look.

Tentatively, I'll plan to release an update Monday evening if nothing comes up between now and then.

Link to comment
Share on other sites


But but but... IT'S A BUG WAHHHHHHHH!!!!!!!!! :cry:




Perhaps, but since this is a free mod that I put out independently, I can choose which bugs I'm going to fix and which I'm going to ignore. mwahaha.

Tell you what: I'll even be extra nice. If the bug is REALLY bothering you (keeping in mind this "bug" only happens when you add a favorite, uninstall the application, and then reinstall it :rolleyes: ...) I'll give you a refund so all parties can walk away happy. :P
Link to comment
Share on other sites


Perhaps, but since this is a free mod that I put out independently, I can choose which bugs I'm going to fix and which I'm going to ignore. mwahaha.


:o So evil!



Tell you what: I'll even be extra nice. If the bug is REALLY bothering you (keeping in mind this "bug" only happens when you add a favorite, uninstall the application, and then reinstall it :rolleyes: ...) I'll give you a refund so all parties can walk away happy. :P


That includes my time spent on finding the bug right? I get paid $100/hr, minimum of one hour. :lol:
Link to comment
Share on other sites

Go to FTP, open /admin/applications/core/extenstions/usercpForms.php,
Find:

if ( $this->memberData['g_attach_max'] != -1 ) { $array[] = array( 'url' => 'area=attachments', 'title' => ipsRegistry::instance()->getClass('class_localization')->words['m_attach'], 'active' => $this->request['tab'] == 'core' && $this->request['area'] == 'attachments' ? 1 : 0, 'area' => 'attachments' ); }













Add BELOW:

if ( IPSLib::appIsInstalled('bottombar') ) { $array[] = array( 'url' => 'area=bottombar', 'area' => 'bottombar', 'title' => 'Bottom Bar Configuration', 'active' => $this->request['tab'] == 'core' && $this->request['area'] == 'bottombar' ? 1 : 0 ); }











Find:

case 'notes': return $this->showFormNotes(); break;







Add BELOW:

case 'bottombar': return $this->showFormBottomBar(); break;







Find:

case 'notes': return $this->saveFormNotes(); break;







Add BELOW:

case 'bottombar': return $this->saveFormBottomBar(); break;







Find:

/** * UserCP Save Form: Password * * @access public * @param array Array of member / core_sys_login information (if we're editing) * @return mixed Array of errors / boolean true */ public function saveFormPassword( $member=array() ) {













Add ABOVE:

/** * UserCP Save Form: Bottom Bar * * @access public * @author Brandon Farber * @return boolean Successful */ public function saveFormBottomBar( $current_area ) { $_hide = $this->request['hide_bottombar'] ? 1 : 0; IPSMember::packMemberCache( $this->memberData['member_id'], array( 'hide_bottombar' => $_hide ), $this->memberData['_cache'] ); }

















Find:

/** * UserCP Form Check * * @access public * @author Matt Mecham * @param string Current area as defined by 'get_links' * @return string Processed HTML */ public function saveForm( $current_area ) {














Add ABOVE:

/** * Show the Bottom Bar form * * @access public * @author Brandon Farber * @return string Processed HTML */ public function showFormBottomBar() { return $this->registry->output->getTemplate('bottombar')->usercpSettings(); }













Link to comment
Share on other sites


Thats an easy one buddy. Gimme a few. :)




Most Excellent! Thanks a lot!

I was in the right neighborhood... :) Only I was in a wrong directory... I was looking in this directory: /admin/applications/forums/extensions

/me still would've needed help! :blink:


Final question about this move... how can I now remove the top tab where it says bottom bar next to Gallery?

Thanks!
Jamie
Link to comment
Share on other sites


Go to FTP, /admin/applications_addon/other/bottombar/extensions, delete usercpForms.php




Thanks again!

I did delete that file, but then the bottom bar options was blank.. the check box was there, but no text.. I did some experimenting and found by delete this from that file removed the tab, but kept the text in place.

$array = array();

if ( IPSLib::appIsInstalled('bottombar') )
{
$array[] = array( 'url' => 'area=bottombar',
'area' => 'v',
'title' => $this->lang->words['bbucp_title'],
'active' => $this->request['tab'] == 'bottombar' ? 1 : 0 );
}


Thanks again for your help!!

Jamie
Link to comment
Share on other sites

Uploaded 1.0.1 (ignore version numbers, I'm just making them up as I go along).

Fixed the missing settings and upgrade routine (hence the version number jump), and fixed the warning from sources/hooks.php that was reported. I also moved the hook point so that if you disallow users to change skins the bottom bar should still work.

I have NOT tested an install/upgrade. Let some brave soul *cough*Nuclear General*cough* do that before you upgrade, if you're worried about any issues cropping up. :whistle:

Link to comment
Share on other sites


I have NOT tested an install/upgrade. Let some brave soul *cough*Nuclear General*cough* do that before you upgrade, if you're worried about any issues cropping up. :whistle:



Why thank you for the complement Brandon! :D

And Brandon, would you be able to help me solve a small problem I have with a usercpForms.php file? I did a custom edit to the core/extensions/usercpForms.php and I receive an error when saving it. But I do not receive the error on my local install. I posted this at Coders Refuge. And the error points to the $this->MYFUNCTION area of the switch statement in the saveForm and the main line on the actual function it links to "public function saveFormMYFUNCTION".

And all I did was take your existing code for the bottom bar and duplicate it for several settings and put it in an array and it works fine on a local install, but not on my live site. Not sure why, and the code is the exact same on both sites.


*grabs it and suffers*




Edit:


site infected now.. Setting is now showing up.. YAY!



bfarber, is there any way to get it to bump the bottom up without manually editing the skins to add <br/>'s?



I'm afraid not Wolfie. As the bottom bar is a fixed position, it would not be able to bump the bottom up.
Link to comment
Share on other sites


I'm afraid not Wolfie. As the bottom bar is a fixed position, it would not be able to bump the bottom up.



I was thinking more in the way of putting in some css change or something that bumps it up, sort of separate from the bar itself. Basically automatically inserting a couple of <br/>'s if the bar is going to show. Either that or somehow changing the properties of the page so that the browser treats the bottombar as the new bottom (ie, tabbing around won't hide behind the bar).
Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

  • Recently Browsing   0 members

    • No registered users viewing this page.

×
×
  • Create New...