Jump to content

ipb still has bits of html hardcoded which would be useful if it was


Guest BRamburn

Recommended Posts

ipb still has bits of html hardcoded which would be useful if it was converted to template bits.
Like for example in func_boardstats.php
around line 200 there is "<a........." tags and i was thinking of removing $last date to the users group name without php editing.

Link to comment
Share on other sites

It's easy to say, however on the flipside to remove every single bold or anchor tag would end up resulting in 10000 template bits....is THAT worth it? :unsure:

There should be a tradeoff/balance somewhere....we could make a single template for a tags, and all anchor tags use that template, but then you wouldn't be able to remove a title for just ONE section...removing the title would affect all anchor tags generated.

Link to comment
Share on other sites

Couldn't the original suggestor achieve what they want by using conditional HTML in the skin? By and large, if it's hardcoded in the PHP it appears in the skin as a $variable.



Impossible, because there is no member variable passed to that template bit


It's easy to say, however on the flipside to remove every single bold or anchor tag would end up resulting in 10000 template bits....is THAT worth it? :unsure:



There should be a tradeoff/balance somewhere....we could make a single template for a tags, and all anchor tags use that template, but then you wouldn't be able to remove a title for just ONE section...removing the title would affect all anchor tags generated.


yes that could be a downfall.

Anyways when are you guys going to start using the new logic code class_template_engine.php
because when i switched it to class_template.php and started to edit stuff i don't think there were any errors.

But my main point is that the skin isn't flexible enough for big customisation.
Link to comment
Share on other sites

Impossible, because there is no member variable passed to that template bit


It would be nice if there was a certain minimum number of variables passed in to enhance customisations. But PHP, like any programming language, tends to have reduced performance the more parameters that are passed into functions.
Link to comment
Share on other sites

The skinning system allows you to modify the look and feel of the board - it works fine the way it is.

There isn't a way to know in advance what data you may want in any given skin element - in some elements, there may be no relevant "member" information to show. In some, it may not be used (i.e., a poll template - member information isn't used). There isn't a reason to pass it in this case.

You are free to modify your files to actually pass it if you need it available, however I don't see the benefit for 95%+ of our customers to bloat the software by passing around data that isn't needed. I just don't think that will be a viable solution.

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...